From: Randy Dunlap <rdunlap@infradead.org>
To: Piyush Thange <pthange19@gmail.com>,
Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org, shuah@kernel.org
Subject: Re: [PATCH] usb:dwc:core.h Fixed warning of documentation
Date: Tue, 28 Mar 2023 20:36:39 -0700 [thread overview]
Message-ID: <22e509fc-e250-29b3-e9f1-d62a6d10ec60@infradead.org> (raw)
In-Reply-To: <20230329032938.225211-1-pthange19@gmail.com>
Hi--
On 3/28/23 20:29, Piyush Thange wrote:
> While compiling documentation a following warning is generated.
> Function parameter or member 'resume_hs_terminations' not described
> in 'dwc3'
This one appears to be fixed already.
> One more warning arises in the same file as follows
> Function parameter or member 'gfladj_refclk_lpm_sel' not described
> in 'dwc3'
>
> I need some insights on this.
The second one needs a line added, probably just after:
* @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
* instances in park mode.
like
* @gfladj_refclk_lpm_sel: {some description here}
Thanks.
> Signed-off-by: Piyush Thange <pthange19@gmail.com>
> ---
> drivers/usb/dwc3/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 582ebd9cf9c2..4743e918dcaf 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -1098,7 +1098,7 @@ struct dwc3_scratchpad_array {
> * change quirk.
> * @dis_tx_ipgap_linecheck_quirk: set if we disable u2mac linestate
> * check during HS transmit.
> - * @resume-hs-terminations: Set if we enable quirk for fixing improper crc
> + * @resume_hs_terminations: Set if we enable quirk for fixing improper crc
> * generation after resume from suspend.
> * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed
> * instances in park mode.
--
~Randy
prev parent reply other threads:[~2023-03-29 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 3:29 [PATCH] usb:dwc:core.h Fixed warning of documentation Piyush Thange
2023-03-29 3:36 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e509fc-e250-29b3-e9f1-d62a6d10ec60@infradead.org \
--to=rdunlap@infradead.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pthange19@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox