Re: [PATCH V4 1/5] dt-bindings: usb: tegra-xudc: Add dma-coherent for Tegra194

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 16/01/2023 15:54, Jon Hunter wrote:
> DMA operations for XUSB device controller are coherent for Tegra194 and
> so update the device-tree binding to add this property.
> 
> Fixes: 394b012a422d ("dt-bindings: usb: tegra-xudc: Add Tegra194 XUSB controller support")
> 

No blank lines between the tags.

If this is a fix, you need to describe the observed issue or bug. Commit
suggests this is just adding some missing piece, so not a fix for a bug.

> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  .../devicetree/bindings/usb/nvidia,tegra-xudc.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> index f6cb19efd98b..4ef88d38fa3a 100644
> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
> @@ -112,6 +112,8 @@ properties:
>    hvdd-usb-supply:
>      description: USB controller power supply. Must supply 3.3 V.
>  
> +  dma-coherent: true
> +
>  required:
>    - compatible
>    - reg
> @@ -164,6 +166,16 @@ allOf:
>          clock-names:
>            maxItems: 4
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nvidia,tegra194-xudc
> +    then:
> +      required:
> +        - dma-coherent
> +
>  additionalProperties: false
>  
>  examples:

Best regards,
Krzysztof