From: Oliver Neukum <oneukum@suse.com>
To: Zhou jie <zhoujie@nfschina.com>, Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:Modify the return value to void
Date: Thu, 12 May 2022 11:58:08 +0200 [thread overview]
Message-ID: <23cf0d6b-3577-b9c1-e20d-e54b6823f309@suse.com> (raw)
In-Reply-To: <20220512093210.GA6602@localhost.localdomain>
On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void
Hi,
technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.
Regards
Oliver
prev parent reply other threads:[~2022-05-12 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:32 [PATCH] drivers:Modify the return value to void Zhou jie
2022-05-12 9:38 ` Greg Kroah-Hartman
2022-05-12 9:58 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23cf0d6b-3577-b9c1-e20d-e54b6823f309@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhoujie@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).