From: Andrew Lunn <andrew@lunn.ch>
To: Shaoxu Liu <shaoxul@foxmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add power management op for RNDIS host
Date: Mon, 1 Jun 2026 15:09:19 +0200 [thread overview]
Message-ID: <248e3597-c3ca-4e7a-a508-bc9a5b4e41d3@lunn.ch> (raw)
In-Reply-To: <tencent_96AA6EAB892D4596D70BA972ECC3667AC505@qq.com>
On Mon, Jun 01, 2026 at 11:29:19AM +0800, Shaoxu Liu wrote:
> RNDIS host does not manage the USB power, and it will
> cause more power consumption even when no data transferring.
>
> Adding the power management operator will make the USB
> enter suspend mode when no data transferring.
You are doing two things here.
1) Adding a new vendor:Product ID
2) Making that new device manage power.
The commit message does not make this clear. Please split this into
two patches, and make the commit messages better.
Also, please take a read of:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-06-01 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 3:29 [PATCH] Add power management op for RNDIS host Shaoxu Liu
2026-06-01 13:09 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 8:24 Shaoxu Liu
2026-05-27 7:47 Shaoxu Liu
2026-05-27 7:55 ` Greg KH
2026-05-19 7:28 Ivanl S
2026-05-19 9:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248e3597-c3ca-4e7a-a508-bc9a5b4e41d3@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaoxul@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox