Re: So, I had to revert d6d458d42e1 ("Handle DisplayPort tunnel activation asynchronously") too, to stop my resume crashes

Mika Westerberg
2025-03-03T13:23:29Z

On Mon, Mar 03, 2025 at 05:19:27AM -0800, Kenneth Crudup wrote:
>
> >> Oh and the failure mode for d6d458d4 is ALWAYS this, and always(?) from
> line
> >> 436/7 of ".../drivers/thunderbolt/path.c", a call to tb_port_write():
>
> I was looking thru the pstore dumps; it may not ALWAYS be line 436, but it
> is always in "tb_port_write()".
>
> On 3/3/25 05:13, Mika Westerberg wrote:
>
> > That's also weird because we don't do anything for DP tunnels on resume so
> > what this code is doing is to clean up for the tunnels left by the boot
> > kernel (since this is hibernate).
>
> OK, but for completeness' sake the crash happens on a suspend resume as well
> (and the same failure mode as a resume hibernate).

On suspend/resume we don't do anything for the DP tunnels, not even clean
up anything as compared to hibernate so it's double weird that at that
point d6d458d4 affects it in any way.

Since if it is happening over suspend resume, I suggest we stick with that
for repro because it involves simpler code paths.