From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBC2C433FE for ; Tue, 28 Dec 2021 12:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbhL1MUV (ORCPT ); Tue, 28 Dec 2021 07:20:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22376 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231167AbhL1MUQ (ORCPT ); Tue, 28 Dec 2021 07:20:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640694015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5VvjubQBgQXusD/qnqAa/6+So3MqJfcWXAtQ7MU1qeU=; b=WC1ZZZ6hKJHgh0LP91eQ86qFLDCBX+7j5fVdH1HZZj7CgApjg7Fqrq1CdsWTKlk4V7/vxm 8zfCJT5hMYpeA6gAxO1eRLDenpZbdc3u5qcTEGX0Mg7gMzbK/Ee4fIjJeUd20+lJqWeLQ2 xRCGWwYLGuTdlvUaHBLjxoll7sImbgI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-42-uIMQppAbNC6G1w0sf9VQ5w-1; Tue, 28 Dec 2021 07:20:13 -0500 X-MC-Unique: uIMQppAbNC6G1w0sf9VQ5w-1 Received: by mail-ed1-f72.google.com with SMTP id ch27-20020a0564021bdb00b003f8389236f8so12898068edb.19 for ; Tue, 28 Dec 2021 04:20:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5VvjubQBgQXusD/qnqAa/6+So3MqJfcWXAtQ7MU1qeU=; b=iaJlv5vXMAxE8KK3FD/EU7DRObk96iAeViCpP3347xU2okjmnBMir/iyyIziS7AibV zykCS9yqa2NiQH2OkvPXg6/rEW5MYoWTiEvMvX01zeY0ZyStMhsz3ShVnTI/blAIXPDU 419eAM7NvdWHUqI7M7Mli+73l9GS4Gy8HDZ4lsRo8V7v8idHtFz6IEEbx/KwyvqBOiX8 Tp/czPDnfdIhAZ8hpZMWU2ZPMnL/I+ljyWXKg5lLHF9FYtl3U0E16eFs/BqS5tmDW5Dh cx3QVlsdmc7UtccrRutF5h80reAYNWl9/4AD505u0k3viLQbVan7wv+WtcU2KzFg7otk XZtQ== X-Gm-Message-State: AOAM531NLIJDjSHT1/6OiU8RM8SxLCp+YRtAz76MtNKtNNpBhyXEbQIO jMnouoAMJts1JUJIpfK6r7JKPXyUMvbLNQ8EjpNrXgp/mebFil5Q/zpsyFgWFjk1wR9O3zPz6qa HPnrRL1lt+qYX1UZRx3qr X-Received: by 2002:a17:907:60d6:: with SMTP id hv22mr17260602ejc.478.1640694012554; Tue, 28 Dec 2021 04:20:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5XdEog79sJL19FCO0DE7mMk8OhXWL3OTKf+yaTjbtWynbAlqQXyYdTwnhqf6+6U8AWbL0Hg== X-Received: by 2002:a17:907:60d6:: with SMTP id hv22mr17260594ejc.478.1640694012382; Tue, 28 Dec 2021 04:20:12 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id 14sm6007390ejk.215.2021.12.28.04.20.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 04:20:11 -0800 (PST) Message-ID: <279c7bd8-c0bb-e58c-1149-d124102bf8b8@redhat.com> Date: Tue, 28 Dec 2021 13:20:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 0/8] typec: mux: Introduce support for multiple TypeC muxes Content-Language: en-US To: Bjorn Andersson , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Greg Kroah-Hartman , Heikki Krogerus Cc: "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20211228052116.1748443-1-bjorn.andersson@linaro.org> From: Hans de Goede In-Reply-To: <20211228052116.1748443-1-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Bjorn, On 12/28/21 06:21, Bjorn Andersson wrote: > This series introduces a level of indirection between the controller's view of > a typec_mux/switch and the implementation and then expands that to support > multiple drivers. > > This is needed in order to support devices such as the Qualcomm Snapdragon 888 > HDK, which does muxing and orientation handling in the QMP (USB+DP) PHY and SBU > muxing in the external FSA4480 chip. > > Additionally integration of typec mux and switch in the QMP PHY is included in > the series, as is the new FSA4480 driver. This is done to deal with the > renaming of the driver-side typec_mux -> typec_mux_dev. > > Bjorn Andersson (8): > dt-bindings: phy: qcom,qmp-usb3-dp: Add altmode/switch properties > phy: qcom-qmp: Register typec mux and orientation switch > device property: Helper to match multiple connections > device property: Use multi-connection matchers for single case > typec: mux: Introduce indirection > typec: mux: Allow multiple mux_devs per mux > dt-bindings: usb: Add binding for fcs,fsa4480 > usb: typec: mux: Add On Semi fsa4480 driver Thank you for your series, I will leave commenting on the dt-bindings and typec-mux changes to others. But what I can do is test this on an x86 device using a pi3usb30532 mux for USB super-speed and DP-alt-mode muxing / orientation switching. I'm going to wait a bit with doing that till this has had some reviews and possibly also some newer versions because of those reviews. If you haven't received a Tested-by from me when this looks like it is ready for merging please ping me. Regards, Hans > > .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 14 + > .../devicetree/bindings/usb/fcs,fsa4480.yaml | 72 +++++ > drivers/base/property.c | 83 ++++-- > drivers/phy/qualcomm/phy-qcom-qmp.c | 176 ++++++++++-- > drivers/usb/typec/bus.c | 2 +- > drivers/usb/typec/mux.c | 257 +++++++++++++----- > drivers/usb/typec/mux.h | 12 +- > drivers/usb/typec/mux/Kconfig | 9 + > drivers/usb/typec/mux/Makefile | 1 + > drivers/usb/typec/mux/fsa4480.c | 220 +++++++++++++++ > drivers/usb/typec/mux/intel_pmc_mux.c | 8 +- > drivers/usb/typec/mux/pi3usb30532.c | 8 +- > include/linux/property.h | 5 + > include/linux/usb/typec_mux.h | 22 +- > 14 files changed, 762 insertions(+), 127 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml > create mode 100644 drivers/usb/typec/mux/fsa4480.c >