From: Oliver Neukum <oneukum@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
stable <stable@kernel.org>
Subject: Re: [PATCH net] net: usb: cdc_ncm: reject negative chained NDP offsets
Date: Mon, 13 Apr 2026 10:36:19 +0200 [thread overview]
Message-ID: <2a6963c8-4a87-4fed-b875-d46f3ce53e42@suse.com> (raw)
In-Reply-To: <2026041137-comfy-eaten-a1ed@gregkh>
On 11.04.26 12:53, Greg Kroah-Hartman wrote:
> cdc_ncm_rx_fixup() reads dwNextNdpIndex from each NDP32 to chain to the
> next one. The 32-bit value from the device is stored into the signed
> int ndpoffset so that means values with the high bit set become
Well, then isn't the problem rather that you should not store an
unsigned value in a signed variable?
Regards
Oliver
next prev parent reply other threads:[~2026-04-13 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 10:53 [PATCH net] net: usb: cdc_ncm: reject negative chained NDP offsets Greg Kroah-Hartman
2026-04-13 8:36 ` Oliver Neukum [this message]
2026-04-13 10:43 ` Greg Kroah-Hartman
2026-04-13 12:11 ` Oliver Neukum
2026-04-13 12:24 ` Greg Kroah-Hartman
2026-04-13 16:20 ` Bjørn Mork
2026-04-14 4:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a6963c8-4a87-4fed-b875-d46f3ce53e42@suse.com \
--to=oneukum@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox