From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
JC Kuo <jckuo@nvidia.com>, Nicolas Chauvet <kwizart@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree
Date: Tue, 26 Oct 2021 10:23:16 +0300 [thread overview]
Message-ID: <2c22dc0c-6709-907d-8296-712d77282f0e@gmail.com> (raw)
In-Reply-To: <5f122caa-c810-534d-b2a1-53edef313ff0@gmail.com>
21.10.2021 17:57, Dmitry Osipenko пишет:
> It might be wrong to disable device_may_wakeup() because it will change
> the system suspend-resume behaviour, i.e. you won't be able to resume by
> USB event, see [1].
>
> [1]
> https://elixir.bootlin.com/linux/v5.15-rc6/source/drivers/usb/host/xhci-tegra.c#L1962
>
> Although, I'm not sure whether this is a correct behaviour to start
> with. Previously, before the offending commit, device_wakeup was never
> enabled for tegra-xusb. Commit message doesn't explain why wakeup is now
> enabled unconditionally, wakeup checks aren't needed at all then. This
> makes no sense, please check it with JC Kuo.
I looked at it again and now see that disabling wakeup actually should
restore the old code behaviour properly because previously wakeup wasn't
ever enabled. Alright, I'll prepare v2.
next prev parent reply other threads:[~2021-10-26 7:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:55 [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree Dmitry Osipenko
2021-10-21 14:01 ` Thierry Reding
2021-10-21 14:57 ` Dmitry Osipenko
2021-10-21 15:08 ` Dmitry Osipenko
2021-10-21 15:20 ` Alan Stern
2021-10-21 17:13 ` Dmitry Osipenko
2021-10-21 17:16 ` Dmitry Osipenko
2021-10-21 19:14 ` Alan Stern
2021-10-21 19:17 ` Dmitry Osipenko
2021-10-26 7:23 ` Dmitry Osipenko [this message]
2021-10-21 21:37 ` Michał Mirosław
2021-10-21 21:46 ` Dmitry Osipenko
2021-10-21 22:14 ` Michał Mirosław
2021-10-22 5:58 ` Dmitry Osipenko
2021-10-22 9:29 ` Michał Mirosław
2021-10-22 9:35 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c22dc0c-6709-907d-8296-712d77282f0e@gmail.com \
--to=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox