From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66BBC61DA4 for ; Sat, 18 Mar 2023 13:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbjCRNNp (ORCPT ); Sat, 18 Mar 2023 09:13:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjCRNNo (ORCPT ); Sat, 18 Mar 2023 09:13:44 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36707132DD for ; Sat, 18 Mar 2023 06:13:42 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id g18so7743487ljl.3 for ; Sat, 18 Mar 2023 06:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679145220; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xjmr2nAua78gEqtz1WDKDDPtSDYZ8DpOst2CageaHa0=; b=xp362ba1yyj5PGKIBVIZWfa15y0rAnMlDjjHHP9r6s5+yvKaX1hayfOJGMae1kN5Bk 3nM5IkSzwrvcFxXoSdiVYZHVI2nEqgh8URXC32SBPUeRR9N+F2iAezGxDH5JUBa954Lt bsTHnGiBQhhGmwUIDlffd1WbgCV1bRgATzBkSlEE0HX+vlnrPbwjN7JCX21z8qp27G8N OzcBRaoKOLazd1hPpH7hshwh5FZd6Zgm7ijGrcSo0U9kgsnY9r/nq5bLL/Ggkcbr+mCD JPctzoEXe6aBdyo38+qroygvHpUvy+RE3/re4TnSoa+SNXyj8K4Oj49Hw9aYR598jX85 x1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679145220; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjmr2nAua78gEqtz1WDKDDPtSDYZ8DpOst2CageaHa0=; b=Bskz5f2VigyRf63pyTXVk50djp9aroPZtMYeiRd3Qmsixv7EIIqy+vfisvcdtm1dlu P8XPFEdDDDkpEBdM+DcH1VZdYdaiWz4UL5QAcuHRi5FDrvOBiL1Rx0RtkkUe1vfM4ECY NQvR1BmCUZb/W64rFgMdLPY0YMszgXRFzC/S6RmEEK8tr6qK0JPvy5g7phUnJl769/1q 4kxWYTD/ULqHuiVWrYwqQsw70tR1KypzGA1rvIN/OECRRPsvd2abV7g9vt6rKUIEUBHw FuVlC+Oz0CNGYQ3JLKybuqRIR9bFXD8S2d0jBAdD03DYOF5ObD1pK6L2R3ulmkqGByDS IPWg== X-Gm-Message-State: AO0yUKUg5JtuvTkv5i1hQIbsqhYPJCaVHvcepoSyP15jLZj1wHB1RZvy svCc+40IcFl5FVKrRsqWQzS1UQ== X-Google-Smtp-Source: AK7set/mZURMrzSttemnB8LyVCWsJ/nCFWzbuKXCB3kOdk2TmaO2WL3OUnEsV3sHoL4moxqYNPZcAg== X-Received: by 2002:a2e:95c7:0:b0:29b:c987:b34a with SMTP id y7-20020a2e95c7000000b0029bc987b34amr452925ljh.19.1679145220132; Sat, 18 Mar 2023 06:13:40 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id j21-20020a2e8015000000b00294649d3dcasm881652ljg.44.2023.03.18.06.13.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Mar 2023 06:13:39 -0700 (PDT) Message-ID: <2e197a09-5e66-67f0-bcef-958578a85e75@linaro.org> Date: Sat, 18 Mar 2023 14:13:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 14/18] arm64: dts: qcom: pm8150b: Add a TCPM description Content-Language: en-US To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: wcheng@codeaurora.org, caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230318121828.739424-1-bryan.odonoghue@linaro.org> <20230318121828.739424-15-bryan.odonoghue@linaro.org> From: Konrad Dybcio In-Reply-To: <20230318121828.739424-15-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 18.03.2023 13:18, Bryan O'Donoghue wrote: > Type-C port management functionality lives inside of the PMIC block on > pm8150b. > > The Type-C port management logic controls orientation detection, vbus/vconn > sense and to send/receive Type-C Power Domain messages. > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 70 +++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > index 66752cc063d60..6db32bdbf5747 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -7,6 +7,8 @@ > #include > #include > #include > +#include > +#include > > / { > thermal-zones { > @@ -37,6 +39,14 @@ trip2 { > }; > }; > }; > + > + tcpm: pm8150b-tcpm { > + compatible = "qcom,pmic-virt-tcpm"; > + qcom,pmic-typec = <&pm8150b_typec>; > + qcom,pmic-pdphy = <&pm8150b_pdphy>; > + > + status = "disabled"; > + }; > }; > > &spmi_bus { > @@ -59,6 +69,66 @@ pm8150b_vbus: usb-vbus-regulator@1100 { > reg = <0x1100>; > }; > > + pm8150b_typec: typec@1500 { > + compatible = "qcom,pm8150b-typec"; > + reg = <0x1500>; > + interrupts = <0x2 0x15 PMIC_TYPEC_OR_RID_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x15 PMIC_TYPEC_VPD_IRQ > + IRQ_TYPE_EDGE_BOTH>, > + <0x2 0x15 PMIC_TYPEC_CC_STATE_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x15 PMIC_TYPEC_VCONN_OC_IRQ > + IRQ_TYPE_EDGE_BOTH>, > + <0x2 0x15 PMIC_TYPEC_VBUS_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x15 PMIC_TYPEC_ATTACH_DETACH_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x15 PMIC_TYPEC_LEGACY_CABLE_IRQ > + IRQ_TYPE_EDGE_BOTH>, > + <0x2 0x15 PMIC_TYPEC_TRY_SNK_SRC_IRQ > + IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "or-rid-detect-change", > + "vpd-detect", > + "cc-state-change", > + "vconn-oc", > + "vbus-change", > + "attach-detach", > + "legacy-cable-detect", > + "try-snk-src-detect"; > + vdd-vbus-supply = <&pm8150b_vbus>; This belongs in the board dt, it references nodes defined there. > + }; > + > + pm8150b_pdphy: pdphy@1700 { > + compatible = "qcom,pm8150b-pdphy"; > + reg = <0x1700>; > + interrupts = <0x2 0x17 PMIC_PDPHY_SIG_TX_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_SIG_RX_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_MSG_TX_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_MSG_RX_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_MSG_TX_FAIL_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_MSG_TX_DISCARD_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_MSG_RX_DISCARD_IRQ > + IRQ_TYPE_EDGE_RISING>, > + <0x2 0x17 PMIC_PDPHY_FR_SWAP_IRQ > + IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "sig-tx", > + "sig-rx", > + "msg-tx", > + "msg-rx", > + "msg-tx-failed", > + "msg-tx-discarded", > + "msg-rx-discarded", > + "fr-swap"; > + vdd-phy-supply = <&vreg_l2a_3p1>; This belongs in the board dt, it references nodes defined there. The rest lgtm, I think! Konrad > + }; > + > pm8150b_temp: temp-alarm@2400 { > compatible = "qcom,spmi-temp-alarm"; > reg = <0x2400>;