From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D323930D3E8 for ; Thu, 10 Sep 2026 01:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789004240; cv=none; b=bXHmX/RaGeLOzX9lvMCfTGy5KScioZSHvQxQIVvrd+WZnsO1kdodE3ag/NeO/Apr3ZntR3AmQviGVO7wzRdvZOjujZdtF36pQSLlak0WmZATtTyzSKkA2Rvp6l5yclwUJjNGs1schMXbq/SOOgP3pMLBlEPF32G0ulnkDfO+XcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789004240; c=relaxed/simple; bh=NQgzUm2oapDD9XOauvQ7sAF3oBMmE2JcTiMHT0AxIWo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NqozucwQeN3m6foCx2vUDhcXI8TeUnegeboUn2adFo2dZVZS6sb23ri8990tzNSH6UAyovH10JW/BcBL1+g62jpfU2vHxWmW7sKSJQYqFx2vUdA3ag/e8O0W19nSfhpmV8Ct8dNh8yDkKhVZterQUAe13+RLNoSrdVd55M5Wlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X9qqchTF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cQ7RS0tP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X9qqchTF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cQ7RS0tP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689M9lK63138349 for ; Thu, 10 Sep 2026 01:37:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=X9qqchTFThwZILnx WLAh78kMLrph0xponvvrQXZohS+3D67K0JIwO7Prm2SRLb+rC2F6A2119+ztrj1Q ylXqkSIyJjtEGMRcpN/Fai9Sw4BNaWtS+BKTh72cQw3UTb1Vl11vz+QcpTzggSX5 t8j2DZg4jbOEC+6fkJ1NCCaGV7VT0f13EuJ64GrtWXi4LJfXyTUDg9zOegbUHJd5 6Juf6VhvzQAha7gvkmrnqmtbOC3u+U13LTdOLYJtAMkBPMD+3uh8mNPkmSc7VJAK JD2j7Fl68ZmlOR0jGE0XkxDroabXxYEce/9lHUj9gqeDNM5p8Qe2lDNbb75EnwI7 lWlNew== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkcyfsj0d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 10 Sep 2026 01:37:17 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-398d7e0f3b4so2159710a91.3 for ; Wed, 09 Sep 2026 18:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789004237; x=1789609037; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=cQ7RS0tPOl2PLFHHVXTd1FNNZ5GKsnr0Es2dAwOuRmkSwsbmA5JVl2/OEPsFYPXoNP vRtzzNRc7F3HUAzUy9CFEypqRFMFqfG/Iw8faZL6s3ICBrpTf9w8lDu5Ltm9mmsMKbdZ 1+9BZAu9ltmy3VYZhPRBeyatijukAyld34YNldMFIIxO8Keokr/OyiIo4iyGRRtnt4vd wmlbrslyJVFfmeS+ftdNLBrNsJTuO2yqXHcKmGium3oezZ53FqKg1TtDAQPjUpIwV6Uf C8T4GYsdT6b1c+6+/iUvsQ0lSVa5RLRxaNNydXKHDEl/kmZF2IIxOrz7An0fb05yvvpc q28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789004237; x=1789609037; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U5296QULjbatYMz6kpvnqDY9ew8mUlm8s2jfQjulqY4=; b=c24AQACuGrwHie7KavqtFNQITQ1mf7lnAmQNhzvkLL1sR/fKS465yAbiThFHx2yvPH 3GeSAsB3wPt2OPMVw29AT9lLExkQoxARHsrNb7yJiR4Ybmu1X/U61qSkiDnoeFQBbkdu VEuzVsiIa4T8Pwha34HYVX2KP/lZBbWLQOjkCqIwVrhKsU7S3pL0RmoViJlABZhql4/T kOgoCpWjYgKl9HueKSRSWUCnGeWW6G21h0fEvOOstEbRxYwavbYpXz+A8PYPYeW/vqD+ AnwT02Cs0wJUAoPhJxD7XYXSozR+/RQUoOFkiNYAV7NhOqAyjB02jsHmpWZraORAozus qePw== X-Forwarded-Encrypted: i=1; AKwUvBxkh0DVoswTHbjyLZL9RL44HRKujzh+PRB4xLvUwCV3zJGtjDc1w5swr8P+RTcUBEucSKKCoQ7Fj6E=@vger.kernel.org X-Gm-Message-State: AFuF++l+CgyFdUjZxXxFSLCQsrFa2xd38ApmVeknUlgs815VVhsTxXHC phYp0+Yt5gx78W594Nms7qH5IVLdcWoDW5pvXc/Xb3JGoFQthJ0TP+OB98/NdW49XPkA6PanQjr BM7mgWKg6CR5CXIZhJjKd+KyukPSFn4R+QD86qdKsgN/8iSqTw+qC+IA1PfW7P1w= X-Gm-Gg: AYBFou0tGNxOMcmGcjUgINpSz6RdphOMvh2VFUNyb0RkgEOZ8XUMgINtPaW+U3K8RVH tx674aNUthr+o7pNaAI+4Z9MlFI/GkHJxW/PjyXzBKIWYgnEEL288z7b/Oo6VT35+V5LIqiioVr fFfI72N110W6fcPYyzLmSLOPRoMuvfOZfjyytdGnk0V0EtOjc7013hCEQRFL+kIOUt9IehdCfHd /nCLRI1eMODBQDfzEtl/VpIhblAxmnE2+14ppDcNgTuxkr7VmHMUF4PNziC9xb2GvTefRZ/SyLW EFAY/A9idJvy+hLxijgnlaKjVmq0zfoFMZ4ETjLSFHTDqLQkcVXsHB/I9Jz77Mwbh2+a+vKoEeY Xx3IS4jNxMD6pFh8XUQFbD68BmUtlRQ== X-Received: by 2002:a17:90b:380a:b0:39b:2b10:d05c with SMTP id 98e67ed59e1d1-39d709e73a6mr5758511a91.5.1789004236763; Wed, 09 Sep 2026 18:37:16 -0700 (PDT) X-Received: by 2002:a17:90b:380a:b0:39b:2b10:d05c with SMTP id 98e67ed59e1d1-39d709e73a6mr5758465a91.5.1789004236325; Wed, 09 Sep 2026 18:37:16 -0700 (PDT) Received: from [192.168.1.132] ([70.95.199.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1433171a97esm52774345c88.12.2026.09.09.18.37.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 18:37:15 -0700 (PDT) Message-ID: <2ea2d992-d14d-4b26-91f3-c36a87acf82a@oss.qualcomm.com> Date: Wed, 9 Sep 2026 18:37:14 -0700 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/8] usb: misc: qcom_eud: add role-based EUD control To: Konrad Dybcio , Bjorn Andersson , Conor Dooley , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Chen References: <20260831030147.1500616-1-elson.serrao@oss.qualcomm.com> <20260831030147.1500616-7-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Elson Serrao In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: rKW32TAgm_jHHFi_KWFGvx52VCLK_kWQ X-Authority-Analysis: v=2.4 cv=GNqdgeNK c=1 sm=1 tr=0 ts=6aa209cd cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=uHxescsG3rBdxcXwcPaeSg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=c3QgA-9rzyVlc7GNB-wA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: rKW32TAgm_jHHFi_KWFGvx52VCLK_kWQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDAxNiBTYWx0ZWRfXyGeGcne/GUxS IdINOih5b1BkxHHOr7ynNCywvlnVnjukRmQxLtbVlYeKBi1qQdL+RUh0SJjJzVOiZmdmJyEUuhU nCj98X31Q2tjamKPDsiQzhpIOJuidM8pW7Omy3BcXICXTplcSuCqu4PXJjz5j2jotXSUuFFG6WC hUrCXnVSgXsUBnH0ZxM9HRy8gqQLw/Cxf2lT3OuXjRKZ9aJSX4DTGVbjsmO5faKl6QytpPf1Rfc dDs4WhA0R6mA2M4p2f4NNdW+KsDshA9BjH//4iDPlz/mqzXwhNGIF0P9vAsOH2TZeINs90sUrkj mA8MQqWtLYR9GJR1GywcqKhwd7TEBiexlmbrwj0I4nXy9baJVw43SDHKJ8PIKgmQ4wCdjkQkN4k BGLC0UxTdnHU54bV0ihYRoz120RbMXnskM0Qzn1SGVOaLkPcub7yJbA7prTXWZ+q9/u2Js9oljh 6LkfwmcS3MRvtt+jIoQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDAxNiBTYWx0ZWRfX5sbZksJdcZL6 mezhc7K5a1ogdx4VTpERucRUzuLqD4R+aze5eIWxWJBIv0Rf1CCZFG9wIsbIUodWa85LPkRKhAd jqGryGn0GBqqHXM5CJDMw9k0EwYca/c= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-09_02,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100016 On 9/1/2026 4:36 AM, Konrad Dybcio wrote: > On 8/31/26 5:01 AM, Elson Serrao wrote: >> EUD functions by presenting itself as a USB device to the host PC and is >> therefore only applicable when the port operates in device role. Keeping >> EUD enabled in other roles provides no benefit and unnecessarily keeps >> the associated PHY resources enabled. Furthermore, enabling EUD in host >> role can cause the USB controller to misbehave because the EUD hub >> supports only a single upstream-facing port. > > [...] > >> struct eud_chip *chip = dev_get_drvdata(dev); >> + struct eud_path *path; >> bool enable; >> int ret; >> >> if (kstrtobool(buf, &enable)) >> return -EINVAL; >> >> + guard(mutex)(&chip->state_lock); > > GPT suggests port_store() should also take this lock.. I think that's > a valid concern > Thanks for the review, and apologies for the delayed response. I'll address this as well as the other relevant feedback from Sashiko in v8. Thanks, Elson