From: Shuah <shuah@kernel.org>
To: Sergey Shtylyov <sergei.shtylyov@gmail.com>,
valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
gregkh@linuxfoundation.org, ignacio@hernandez-ros.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: Reduce CONNRESET message noise in dmesg from stub
Date: Wed, 21 Jan 2026 15:00:07 -0700 [thread overview]
Message-ID: <2ff6dbbf-010b-4ce1-96e4-1bdacf0d121f@kernel.org> (raw)
In-Reply-To: <aef9a040-aa24-40f2-83ae-44d2c74dc759@gmail.com>
On 1/21/26 13:38, Sergey Shtylyov wrote:
> On 1/21/26 7:37 PM, Shuah Khan wrote:
>
>> stub_complete() prints informational messages for each urb unlink
>> filling dmesg. Change the message to dev_dbg() similar to vhci
>> reports the CONNRESET condition.
>>
>> Reported-by: Ignacio Hernandez-Ros <ignacio@hernandez-ros.com>
>> Closes: https://lore.kernel.org/all/0101019b92e81c20-09906fb4-d5e8-40a6-9192-ab693eef4179-000000@us-west-2.amazonses.com/
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>> ---
>> drivers/usb/usbip/stub_tx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
>> index 55919c3762ba..4cae452bfadb 100644
>> --- a/drivers/usb/usbip/stub_tx.c
>> +++ b/drivers/usb/usbip/stub_tx.c
>> @@ -55,7 +55,7 @@ void stub_complete(struct urb *urb)
>> "stopped by a call to usb_kill_urb() because of cleaning up a virtual connection\n");
>> return;
>> case -ECONNRESET:
>> - dev_info(&urb->dev->dev,
>> + dev_dbg(&urb->dev->dev,
>> "unlinked by a call to usb_unlink_urb()\n");
>
> Please re-align this line for it to start under & again.
I missed that - thanks - will do that in v2.
thanks,
-- Shuah
next prev parent reply other threads:[~2026-01-21 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 16:37 [PATCH] usbip: Reduce CONNRESET message noise in dmesg from stub Shuah Khan
2026-01-21 20:38 ` Sergey Shtylyov
2026-01-21 22:00 ` Shuah [this message]
2026-01-22 11:03 ` Ignacio Hernández-Ros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff6dbbf-010b-4ce1-96e4-1bdacf0d121f@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=ignacio@hernandez-ros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox