From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
USB <linux-usb@vger.kernel.org>
Subject: [3/4] usb: dwc3: trace: log ep commands in hex
Date: Thu, 23 Aug 2018 15:03:08 +0300 [thread overview]
Message-ID: <307008530.cuojA91ImP@avalon> (raw)
Hi Andy,
On Thursday, 23 August 2018 12:57:57 EEST Andy Shevchenko wrote:
> On Mon, Aug 20, 2018 at 3:21 PM Laurent Pinchart wrote:
> > On Monday, 20 August 2018 15:06:31 EEST Andy Shevchenko wrote:
> >> On Mon, Aug 20, 2018 at 2:25 PM, Laurent Pinchart wrote:
> >>>> - TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status:
> >>>> %s",
> >>>> + TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status:
> >>>> %s",
> >>>
> >>> How about 0x%x ?
> >>
> >> Side note: # is one character less for the same.
> >
> > Doesn't that print 0 instead of 0x0 ? There's no ambiguity with 0, but I
> > find that always printing the 0x is more consistent. I'll leave that up
> > to Felipe, I'm OK with both options.
>
> # The value should be converted to an "alternate form".
> For o conversions, the first character of
> the output string is made zero (by prefixing a 0 if it
> was not zero already). For x and X con‐
> versions, a nonzero result has the string "0x" (or "0X"
> for X conversions) prepended to it.
That's exactly my point, it will only prepend 0x when the value is not zero.
Small inconsistency, but I don't mind too much.
next reply other threads:[~2018-08-23 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 12:03 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-23 9:57 [3/4] usb: dwc3: trace: log ep commands in hex Andy Shevchenko
2018-08-20 12:22 Laurent Pinchart
2018-08-20 12:06 Andy Shevchenko
2018-08-20 11:25 Laurent Pinchart
2018-08-20 10:30 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307008530.cuojA91ImP@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=andy.shevchenko@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).