Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

Hans de Goede
2021-05-04T15:35:56Z

Hi,

On 5/4/21 5:10 PM, Heikki Krogerus wrote:
>> +/**
>> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector
>> + * @connector: connector to report the event on
>> + * @data: data related to the event
>> + *
>> + * On some hardware a hotplug event notification may come from outside the display
>> + * driver / device. An example of this is some USB Type-C setups where the hardware
>> + * muxes the DisplayPort data and aux-lines but does not pass the altmode HPD
>> + * status bit to the GPU's DP HPD pin.
>> + *
>> + * This function can be used to report these out-of-band events after obtaining
>> + * a drm_connector reference through calling drm_connector_find_by_fwnode().
>> + */
>> +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode,
>> + struct drm_connector_oob_hotplug_event_data *data)
>> +{
>> + struct drm_connector *connector;
>> +
>> + connector = drm_connector_find_by_fwnode(connector_fwnode);
>> + if (IS_ERR(connector))
>> + return;
>> +
>> + if (connector->funcs->oob_hotplug_event)
>> + connector->funcs->oob_hotplug_event(connector, data);
>> +
>> + drm_connector_put(connector);
>> +}
>> +EXPORT_SYMBOL(drm_connector_oob_hotplug_event);
>
> So it does looks like the "data" parameter is not needed at all:

Well Imre did indicate that having the number of lanes is useful, so
for the next version I'll drop the orientation but I plan to keep
the number of lanes if that is ok with you.

Not having passing along this info was one of the reasons why my
previous attempt at this was nacked, so dropping it all together
feels wrong.

Regards,

Hans