From: Shuah Khan <skhan@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>,
valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usb: usbip: stub_rx: remove outdated comment
Date: Thu, 8 Oct 2026 04:03:49 -0600 [thread overview]
Message-ID: <334b9688-093f-4181-a3eb-eca2d1c8755a@linuxfoundation.org> (raw)
In-Reply-To: <20261005125842.197848-1-oneukum@suse.com>
On 10/5/26 06:58, Oliver Neukum wrote:
> After removal of the BUG() statement the error exit can be reached
> and logs a report. Remove a comment saying otherwise.
>
> Fixes: 635f545a7e8be ("usbip: fix stub_rx: get_pipe() to validate endpoint number")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/usb/usbip/stub_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c
> index 1e9ae578810d..0ccc05b76c5a 100644
> --- a/drivers/usb/usbip/stub_rx.c
> +++ b/drivers/usb/usbip/stub_rx.c
> @@ -391,7 +391,6 @@ static int get_pipe(struct stub_device *sdev, struct usbip_header *pdu)
> }
>
> err_ret:
> - /* NOT REACHED */
> dev_err(&sdev->udev->dev, "CMD_SUBMIT: invalid epnum %d\n", epnum);
> return -1;
> }
Looks good to me.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2026-10-08 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 12:58 [PATCH] usb: usbip: stub_rx: remove outdated comment Oliver Neukum
2026-10-06 16:23 ` sashiko-bot
2026-10-08 10:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=334b9688-093f-4181-a3eb-eca2d1c8755a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox