From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE825CA9EC4 for ; Wed, 30 Oct 2019 01:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BF3C2086A for ; Wed, 30 Oct 2019 01:00:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbfJ3BAY (ORCPT ); Tue, 29 Oct 2019 21:00:24 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33438 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfJ3BAY (ORCPT ); Tue, 29 Oct 2019 21:00:24 -0400 Received: by mail-pg1-f194.google.com with SMTP id u23so299704pgo.0; Tue, 29 Oct 2019 18:00:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bkYH8mBJohAzM8EeM5/4lI2OEt40flkn7/kBdc06wFU=; b=QidqnA9Aan4PSqBxQbP0NfaTxfJ1A39+Yzyjyr8DMcKNy1hxR/Tzfx5vsovVkh0QJ9 JwW74UbIMxziaiTSkom1asbNu6Ugy1pn4UjqJQsDVDbNE0zOIbVNAkbj9IZNf+K6zMF5 69regl0Z3Dp+YWkDb9sOHwiy7Ku0HF9hhahTV0TZs5kb0aWSkt3ULUoDmz9fTjARj5hd i6w9+2NI82aQYHIjLys+qmUC/6D2Am2JorNHMi+ru++x+QJfbJkljg/XnbluQ2qRQ/HI +JALeX+Qp5k453rKnwaxHtHtXyBLssQ8AK/a3KH2H6t+D3g809QQGhGD5l5xXgMpvM+r 5fHQ== X-Gm-Message-State: APjAAAX436+/7IQXcE92pk7EfHe0hSBMxKtiSIxkw7T49sz0Doi7YPki TIlUV/XVxahsP1AmUwGzlzM= X-Google-Smtp-Source: APXvYqwnQq6aGIIPnJpW0Y5UaN69aTFg16AH4jDSXxoISMwLlNOCrmzxiQDn+sy426MhkmidTv9Qpg== X-Received: by 2002:a17:90a:8d82:: with SMTP id d2mr10632046pjo.31.1572397223482; Tue, 29 Oct 2019 18:00:23 -0700 (PDT) Received: from localhost.localdomain ([2601:647:4000:bd:e0c6:a0a4:45b:aac0]) by smtp.gmail.com with ESMTPSA id m65sm3205807pje.3.2019.10.29.18.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2019 18:00:22 -0700 (PDT) Subject: Re: [PATCH] scsi: Fix scsi_get/set_resid() interface To: dgilbert@interlog.com, Damien Le Moal , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-usb@vger.kernel.org" , "usb-storage@lists.one-eyed-alien.net" , Alan Stern , Greg Kroah-Hartman Cc: Justin Piszcz References: <20191028105732.29913-1-damien.lemoal@wdc.com> <4eb733b9-8f52-a6c2-eb56-f0759113dc1e@interlog.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <368dcef6-fbb8-a6b8-d6bb-127d33c41598@acm.org> Date: Tue, 29 Oct 2019 18:00:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <4eb733b9-8f52-a6c2-eb56-f0759113dc1e@interlog.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 2019-10-29 10:59, Douglas Gilbert wrote: > Linux's internal representation is wrong and should be fixed to match > its exposed interface (struct sg_io_hdr) which predates the breakage. If resid_len is changed from unsigned int to int all SCSI core and SCSI LLD code that uses resid_len will have to be reviewed to see whether it handles residual overflow correctly. Bart.