Linux USB
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Hayes Wang <hayeswang@realtek.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
	nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, edumazet@google.com, bjorn@mork.no,
	pabeni@redhat.com
Subject: Re: [PATCH net-next v2 1/2] r8152: remove queuing rx packets in driver
Date: Tue, 19 Sep 2023 14:08:08 +0200	[thread overview]
Message-ID: <369f3139-4e63-4327-8745-2d72d7dfea8f@lunn.ch> (raw)
In-Reply-To: <20230919031351.7334-430-nic_swsd@realtek.com>

> -	return work_done;
> +	if (work_done > budget)
> +		return budget;
> +	else
> +		return work_done;
>  }

I don't know NAPI too well. Are there implications of not telling it
the truth?

    Andrew

  reply	other threads:[~2023-09-19 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  3:13 [PATCH net-next v2 0/2] r8152: modify rx_bottom Hayes Wang
2023-09-19  3:13 ` [PATCH net-next v2 1/2] r8152: remove queuing rx packets in driver Hayes Wang
2023-09-19 12:08   ` Andrew Lunn [this message]
2023-09-19 12:26     ` Hayes Wang
2023-09-21 13:39       ` Paolo Abeni
2023-09-22  5:11         ` Hayes Wang
2023-09-19  3:13 ` [PATCH net-next v2 2/2] r8152: use napi_gro_frags Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=369f3139-4e63-4327-8745-2d72d7dfea8f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox