From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: io_edgeport: fix up switch fall-through comments From: "Gustavo A. R. Silva" Message-Id: <3bc6210d-91e4-94e5-ea8e-077066c1b7cb@embeddedor.com> Date: Thu, 2 May 2019 12:45:39 -0500 To: Greg Kroah-Hartman , Johan Hovold Cc: linux-usb@vger.kernel.org List-ID: T24gNS8yLzE5IDEyOjM1IFBNLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3JvdGU6Cj4gR3VzdGF2byBo YXMgYmVlbiB3b3JraW5nIHRvIGZpeCB1cCBhbGwgb2YgdGhlIHN3aXRjaCBzdGF0ZW1lbnRzIHRo YXQKPiAiZmFsbCB0aHJvdWdoIiBzdWNoIHRoYXQgd2UgY2FuIGV2ZW50dWFsbHkgdHVybiBvbgo+ IC1XaW1wbGljaXQtZmFsbHRocm91Z2guICBBcyBwYXJ0IG9mIHRoYXQsIHRoZSBpb19lZGdlcG9y dC5jIGRyaXZlciBpcyBhCj4gYml0ICJtZXNzeSIgd2l0aCB0aGUgcGFyc2luZyBsb2dpYyBvZiBh IGRhdGEgcGFja2V0LiAgQ2xlYW4gdGhhdCBsb2dpYwo+IHVwIGEgYml0IGJ5IHVuaW5kZW50aW5n IG9uZSBsZXZlbCBvZiB0aGUgbG9naWMsIGFuZCBwcm9wZXJseSBsYWJlbAo+IC8qIEZhbGwgdGhy b3VnaCAqLyB0byBtYWtlIGdjYyBoYXBweS4KPiAKPiBSZXBvcnRlZC1ieTogR3VzdGF2byBBLiBS LiBTaWx2YSA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBHcmVnIEty b2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+IAoKQWNrZWQtYnk6IEd1 c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+CgoKVGhhbmtzLCBHcmVn LgotLS0KR3VzdGF2bwoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vw b3J0LmMgYi9kcml2ZXJzL3VzYi9zZXJpYWwvaW9fZWRnZXBvcnQuYwo+IGluZGV4IDRjYTMxYzBl NDE3NC4uNDhhNDM5Mjk4YTY4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL3NlcmlhbC9pb19l ZGdlcG9ydC5jCj4gKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL2lvX2VkZ2Vwb3J0LmMKPiBAQCAt MTc1MSw3ICsxNzUxLDcgQEAgc3RhdGljIHZvaWQgcHJvY2Vzc19yY3ZkX2RhdGEoc3RydWN0IGVk Z2Vwb3J0X3NlcmlhbCAqZWRnZV9zZXJpYWwsCj4gIAkJCQllZGdlX3NlcmlhbC0+cnhTdGF0ZSA9 IEVYUEVDVF9IRFIyOwo+ICAJCQkJYnJlYWs7Cj4gIAkJCX0KPiAtCQkJLyogb3RoZXJ3aXNlLCBk cm9wIG9uIHRocm91Z2ggKi8KPiArCQkJLyogRmFsbCB0aHJvdWdoICovCj4gIAkJY2FzZSBFWFBF Q1RfSERSMjoKPiAgCQkJZWRnZV9zZXJpYWwtPnJ4SGVhZGVyMiA9ICpidWZmZXI7Cj4gIAkJCSsr YnVmZmVyOwo+IEBAIC0xNzkwLDI5ICsxNzkwLDIwIEBAIHN0YXRpYyB2b2lkIHByb2Nlc3NfcmN2 ZF9kYXRhKHN0cnVjdCBlZGdlcG9ydF9zZXJpYWwgKmVkZ2Vfc2VyaWFsLAo+ICAJCQkJCQllZGdl X3NlcmlhbC0+cnhIZWFkZXIyLCAwKTsKPiAgCQkJCWVkZ2Vfc2VyaWFsLT5yeFN0YXRlID0gRVhQ RUNUX0hEUjE7Cj4gIAkJCQlicmVhazsKPiAtCQkJfSBlbHNlIHsKPiAtCQkJCWVkZ2Vfc2VyaWFs LT5yeFBvcnQgPQo+IC0JCQkJICAgIElPU1BfR0VUX0hEUl9QT1JUKGVkZ2Vfc2VyaWFsLT5yeEhl YWRlcjEpOwo+IC0JCQkJZWRnZV9zZXJpYWwtPnJ4Qnl0ZXNSZW1haW5pbmcgPQo+IC0JCQkJICAg IElPU1BfR0VUX0hEUl9EQVRBX0xFTigKPiAtCQkJCQkJZWRnZV9zZXJpYWwtPnJ4SGVhZGVyMSwK PiAtCQkJCQkJZWRnZV9zZXJpYWwtPnJ4SGVhZGVyMik7Cj4gLQkJCQlkZXZfZGJnKGRldiwgIiVz IC0gRGF0YSBmb3IgUG9ydCAldSBMZW4gJXVcbiIsCj4gLQkJCQkJX19mdW5jX18sCj4gLQkJCQkJ ZWRnZV9zZXJpYWwtPnJ4UG9ydCwKPiAtCQkJCQllZGdlX3NlcmlhbC0+cnhCeXRlc1JlbWFpbmlu Zyk7Cj4gLQo+IC0JCQkJLyogQVNTRVJUKERldkV4dC0+UnhQb3J0IDwgRGV2RXh0LT5OdW1Qb3J0 cyk7Cj4gLQkJCQkgKiBBU1NFUlQoRGV2RXh0LT5SeEJ5dGVzUmVtYWluaW5nIDwKPiAtCQkJCSAq CQlJT1NQX01BWF9EQVRBX0xFTkdUSCk7Cj4gLQkJCQkgKi8KPiAtCj4gLQkJCQlpZiAoYnVmZmVy TGVuZ3RoID09IDApIHsKPiAtCQkJCQllZGdlX3NlcmlhbC0+cnhTdGF0ZSA9IEVYUEVDVF9EQVRB Owo+IC0JCQkJCWJyZWFrOwo+IC0JCQkJfQo+IC0JCQkJLyogRWxzZSwgZHJvcCB0aHJvdWdoICov Cj4gIAkJCX0KPiArCj4gKwkJCWVkZ2Vfc2VyaWFsLT5yeFBvcnQgPSBJT1NQX0dFVF9IRFJfUE9S VChlZGdlX3NlcmlhbC0+cnhIZWFkZXIxKTsKPiArCQkJZWRnZV9zZXJpYWwtPnJ4Qnl0ZXNSZW1h aW5pbmcgPSBJT1NQX0dFVF9IRFJfREFUQV9MRU4oZWRnZV9zZXJpYWwtPnJ4SGVhZGVyMSwKPiAr CQkJCQkJCQkJICAgICAgZWRnZV9zZXJpYWwtPnJ4SGVhZGVyMik7Cj4gKwkJCWRldl9kYmcoZGV2 LCAiJXMgLSBEYXRhIGZvciBQb3J0ICV1IExlbiAldVxuIiwgX19mdW5jX18sCj4gKwkJCQllZGdl X3NlcmlhbC0+cnhQb3J0LAo+ICsJCQkJZWRnZV9zZXJpYWwtPnJ4Qnl0ZXNSZW1haW5pbmcpOwo+ ICsKPiArCQkJaWYgKGJ1ZmZlckxlbmd0aCA9PSAwKSB7Cj4gKwkJCQllZGdlX3NlcmlhbC0+cnhT dGF0ZSA9IEVYUEVDVF9EQVRBOwo+ICsJCQkJYnJlYWs7Cj4gKwkJCX0KPiArCQkJLyogRmFsbCB0 aHJvdWdoICovCj4gIAkJY2FzZSBFWFBFQ1RfREFUQTogLyogRXhwZWN0IGRhdGEgKi8KPiAgCQkJ aWYgKGJ1ZmZlckxlbmd0aCA8IGVkZ2Vfc2VyaWFsLT5yeEJ5dGVzUmVtYWluaW5nKSB7Cj4gIAkJ CQlyeExlbiA9IGJ1ZmZlckxlbmd0aDsKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5E9C43219 for ; Thu, 2 May 2019 18:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 748662089E for ; Thu, 2 May 2019 18:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726473AbfEBSG6 (ORCPT ); Thu, 2 May 2019 14:06:58 -0400 Received: from gateway30.websitewelcome.com ([192.185.197.25]:25821 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfEBSG6 (ORCPT ); Thu, 2 May 2019 14:06:58 -0400 X-Greylist: delayed 1276 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 May 2019 14:06:57 EDT Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id DF3DBCCEE for ; Thu, 2 May 2019 12:45:40 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id MFm8h7fheYTGMMFm8hCC2e; Thu, 02 May 2019 12:45:40 -0500 X-Authority-Reason: nr=8 Received: from [189.250.119.203] (port=37948 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1hMFm8-002UHD-Fu; Thu, 02 May 2019 12:45:40 -0500 Subject: Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments To: Greg Kroah-Hartman , Johan Hovold Cc: linux-usb@vger.kernel.org References: <20190502173515.GA13801@kroah.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: <3bc6210d-91e4-94e5-ea8e-077066c1b7cb@embeddedor.com> Date: Thu, 2 May 2019 12:45:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190502173515.GA13801@kroah.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.203 X-Source-L: No X-Exim-ID: 1hMFm8-002UHD-Fu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.119.203]:37948 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190502174539.F_UzaJk7qzQjVwivwZkDFrkfObNNp41mUQ9Jpc6YwG0@z> On 5/2/19 12:35 PM, Greg Kroah-Hartman wrote: > Gustavo has been working to fix up all of the switch statements that > "fall through" such that we can eventually turn on > -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a > bit "messy" with the parsing logic of a data packet. Clean that logic > up a bit by unindenting one level of the logic, and properly label > /* Fall through */ to make gcc happy. > > Reported-by: Gustavo A. R. Silva > Signed-off-by: Greg Kroah-Hartman > Acked-by: Gustavo A. R. Silva Thanks, Greg. -- Gustavo > diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c > index 4ca31c0e4174..48a439298a68 100644 > --- a/drivers/usb/serial/io_edgeport.c > +++ b/drivers/usb/serial/io_edgeport.c > @@ -1751,7 +1751,7 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > edge_serial->rxState = EXPECT_HDR2; > break; > } > - /* otherwise, drop on through */ > + /* Fall through */ > case EXPECT_HDR2: > edge_serial->rxHeader2 = *buffer; > ++buffer; > @@ -1790,29 +1790,20 @@ static void process_rcvd_data(struct edgeport_serial *edge_serial, > edge_serial->rxHeader2, 0); > edge_serial->rxState = EXPECT_HDR1; > break; > - } else { > - edge_serial->rxPort = > - IOSP_GET_HDR_PORT(edge_serial->rxHeader1); > - edge_serial->rxBytesRemaining = > - IOSP_GET_HDR_DATA_LEN( > - edge_serial->rxHeader1, > - edge_serial->rxHeader2); > - dev_dbg(dev, "%s - Data for Port %u Len %u\n", > - __func__, > - edge_serial->rxPort, > - edge_serial->rxBytesRemaining); > - > - /* ASSERT(DevExt->RxPort < DevExt->NumPorts); > - * ASSERT(DevExt->RxBytesRemaining < > - * IOSP_MAX_DATA_LENGTH); > - */ > - > - if (bufferLength == 0) { > - edge_serial->rxState = EXPECT_DATA; > - break; > - } > - /* Else, drop through */ > } > + > + edge_serial->rxPort = IOSP_GET_HDR_PORT(edge_serial->rxHeader1); > + edge_serial->rxBytesRemaining = IOSP_GET_HDR_DATA_LEN(edge_serial->rxHeader1, > + edge_serial->rxHeader2); > + dev_dbg(dev, "%s - Data for Port %u Len %u\n", __func__, > + edge_serial->rxPort, > + edge_serial->rxBytesRemaining); > + > + if (bufferLength == 0) { > + edge_serial->rxState = EXPECT_DATA; > + break; > + } > + /* Fall through */ > case EXPECT_DATA: /* Expect data */ > if (bufferLength < edge_serial->rxBytesRemaining) { > rxLen = bufferLength; >