From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB920318135 for ; Wed, 26 Nov 2025 20:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764190224; cv=none; b=MCIOfPpQxv6kbJcEQd4X4pJ5+lGnDhgPMV0j+matLD9ITldiuFpxwWZ7NqS1MAHh2BwyaxqQxKVmD3sU464AHzF1vHVAoBKNdy3ifExspVgOdKQwI2QuwYq3okZmSnVG0zUJGDuPILBHBAiC4GTYGeHCJX4/4NwDWEqVQeiO/ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764190224; c=relaxed/simple; bh=2hcVpa9scm0PygAHV2yhPwb8b1VqKc8achD9dLmNggM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d8bRVmzrEZW1nJZk30nQAnEet8pwMdTLqCryQGJjkBTk5Z7mSB8rO+dmc8A3sK3o6DOHkHnc+qxkgZvr0OdK58eOqgnWHoLLRG7ehVcVwvoFOTwoTwcw14T/yYbH0VsdC7C5dXaFjZ3aNQCzKuZxlFQvCoLiAz7g0t06DP7iEi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HGbDdCz7; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HGbDdCz7" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2953e415b27so1951605ad.2 for ; Wed, 26 Nov 2025 12:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764190221; x=1764795021; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nAe7krNX/FWdcfazYkx0OEalo6w7fciX1p3CljsQHjE=; b=HGbDdCz7fMh9auA5giOKC+up0GbVoGyfdlmnW3fyA3Gxeb/N0VXaJ7h8z9oxYb4vjA g+p+ZRULTy1pYN7EVv5B4HrwMHmGfgjly+28BhEPlXXtD/KWdwSqMfXw9NDqftFHdE/T CXq15IsJHKr6bJHsZs8IrqaLSSTkzKPU2I82uX6u58ZouSHjfKSYxKn/4eti0kglBfqH 6FT1XKbMuy2JP+yi2OjHZQnX1+RHfCIkvrp4b5z+VaJHg6EoexoTIpw0JsUIvp4E42Qi xpVhXmwS0s1ou8X0njK31DhtPHOxTRa4nDS1mJWmErhGiynAQh7U5JJC+nlAPID9A7qR FYOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764190221; x=1764795021; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nAe7krNX/FWdcfazYkx0OEalo6w7fciX1p3CljsQHjE=; b=klxkckjvyUnkvX+o4ZVAIvX3lm8csYtUerPDv5Xqpr4J4Gdl5x9YfM57ClZTBuhLwY d5rcSwmu4uLI9plFJLXhs2lVGh/3m4Dxz9vzlbTCKExPn/LOAnToq/xSEraEafvBg7ID eObU51/JALvHaPqyWIVg7v4c9Tu8eQn4gC9MQK6cnVZ2Kz2dmZjpqJbg1+qZedjx8Pjy 5u9HWbz17H+nbmqwc5KSkBW5jZbNqnpbulcfcoIJdGtIXMMMR8TlAw+h3I4hpfb3h69p umHoc7Vl0RhBUUNDPLi1oNkxeS1HQXSpER9PHnufD4+wUjqMSkQ9kIHOxkPICMfyD+G6 icEg== X-Forwarded-Encrypted: i=1; AJvYcCWugH7Wve4/7HQ5FKFTDsHTXmES5zKzgTGGYVkRCHkdybFYerD+LXoiAFtL3W1cCrNTLoGCtevVN9c=@vger.kernel.org X-Gm-Message-State: AOJu0YzYqerMLg9dJ9Pw+rfc3pwEdDD7LbrgPlxjkDKiEGu8W73fLxPe akwvmx+GnnuBVyJAdczOMwYhxJZkTcGGXil7mdVGH+yu+6CGowuX9CG1LRcHfLW/DA== X-Gm-Gg: ASbGncsZZf1X5PnMa1lN1A/XsyHQQiZdrwUihXHYJhq1g42+8Xq8EK69KwKswNcHevQ fzZjg3FlY31pEWj4vMkCoZBr2BRas7/S4o+4bIc9vr5FZkarHt5I2x6E6YBFUp6LfDLfG/da96t KZwiS6X7DgKKB0htch//loS7NUzReh+siC7Kp8maybCWK09lj3ofaeHHIujCBxo2ahCwfHvAx2w Q5lIOZ/mAhbLJ8rbokacCSOdfVs/PXPHQr9Q2YFLEyKnw628tjQPbaUwPd8/1f49fsio109NKpV hBlkeE2OXgayJ0ZWBZSWCMwGu8CXhmUsHv7JJSzVDg1yDjlPeMVoYTELdMD7XYecqUg7hmjQ+Zp XAmlJCXMoEKYPg+T/VbQCEN2oUsyFkc9Y+X1al0AbRmPYTp/OAdWw9018RHpxTEGN+lvv3qvj5p k680c53dZQZdmsbA3HF5unOnmlAONl/PoXZoK5iW5+8KpoHbvz2HgO/qDAXR11is6Tw9NTQBbwa uxbp54tKnrZAA90aQbciBj4 X-Google-Smtp-Source: AGHT+IFjQZz19LkV6uSbQD7V0osJzTvl1J8TedsGIZ78YPP9aLGTQiFmGEhYv2+QMQ+JGAYgRK90Dg== X-Received: by 2002:a17:902:d4ce:b0:295:596f:8507 with SMTP id d9443c01a7336-29baac9f621mr97893625ad.0.1764190220828; Wed, 26 Nov 2025 12:50:20 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:c116:b1c9:632d:a902? ([2a00:79e0:2e7c:8:c116:b1c9:632d:a902]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b12f988sm203367425ad.27.2025.11.26.12.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 12:50:20 -0800 (PST) Message-ID: <3c72e1f3-7873-4f13-a5cd-0aecc5163aab@google.com> Date: Wed, 26 Nov 2025 12:50:19 -0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] dt-bindings: usb: maxim,max33359: Add supply property for VBUS in OTG mode To: Heikki Krogerus Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Peter Griffin , Tudor Ambarus , Alim Akhtar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20251123-max77759-charger-v1-0-6b2e4b8f7f54@google.com> <20251123-max77759-charger-v1-3-6b2e4b8f7f54@google.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Heikki, On 11/26/25 2:01 AM, Heikki Krogerus wrote: > Sun, Nov 23, 2025 at 08:35:50AM +0000, Amit Sunil Dhamne via B4 Relay kirjoitti: >> From: Amit Sunil Dhamne >> >> Add a regulator supply property for VBUS when usb is in OTG mode. > What is "OTG mode"? > > OTG is usually used to refer to the USB in device role, even though the > specification actually defines OTG device as a device capable of both > host and device roles. So the term was confusing already before. > Nevertheless, the emphasis is always on data-role, _not_ power-role. Thanks for the insight! > > Here it seems MAX33359 uses the term OTG as a synonym for "source", so > power-role? Essentially. The datasheet refers to the mode where VBUS is sourced as OTG mode. > Please don't use the term OTG unless you really have to - it's too > confusing. I know the MAX33359 datasheet uses it, but what you really > do here is regulate VBUS. So please: > > s/otg-vbus/vbus/ I will drop OTG term at least in the USB world and restrict it to the charger driver. BR, Amit > > thanks, > >> Signed-off-by: Amit Sunil Dhamne >> Reviewed-by: Badhri Jagan Sridharan >> --- >> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> index 3de4dc40b791..a529f18c4918 100644 >> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml >> @@ -32,6 +32,9 @@ properties: >> description: >> Properties for usb c connector. >> >> + otg-vbus-supply: >> + description: Regulator to control OTG VBUS supply. >> + >> required: >> - compatible >> - reg >> @@ -53,6 +56,7 @@ examples: >> reg = <0x25>; >> interrupt-parent = <&gpa8>; >> interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >> + otg-vbus-supply = <&otg_vbus_reg>; >> >> connector { >> compatible = "usb-c-connector"; >> >> -- >> 2.52.0.rc2.455.g230fcf2819-goog >>