From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Forest Crossman <cyrozap@gmail.com>, linux-usb@vger.kernel.org
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] usb: xhci: define IDs for various ASMedia host controllers
Date: Wed, 29 Jul 2020 21:08:00 +0300 [thread overview]
Message-ID: <3dbfff9a-e64e-e11f-c032-2bbbb7359c97@gmail.com> (raw)
In-Reply-To: <20200728042408.180529-2-cyrozap@gmail.com>
Hello!
On 7/28/20 7:24 AM, Forest Crossman wrote:
> Not all ASMedia host controllers have a device ID that matches its part
> number. #define some of these IDs to make it clearer at a glance which
> chips require what quirks.
>
> Signed-off-by: Forest Crossman <cyrozap@gmail.com>
> ---
> drivers/usb/host/xhci-pci.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 9234c82e70e4..baa5af88ca67 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
[...]
> @@ -260,13 +262,13 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_LPM_SUPPORT;
>
> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> - pdev->device == 0x1042)
> + pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)
You shouldn't have un-indented it, blends with the branch below.
The 80-column line length limit is history now. :-)
> xhci->quirks |= XHCI_BROKEN_STREAMS;
> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> - pdev->device == 0x1142)
> + pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI)
> xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
> - pdev->device == 0x2142)
> + pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI)
> xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
>
> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
MBR, Sergei
next prev parent reply other threads:[~2020-07-29 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:06 [PATCH 0/2] Small fixes for ASMedia host controllers Forest Crossman
2020-07-27 9:06 ` [PATCH 1/2] usb: xhci: define IDs for various " Forest Crossman
2020-07-27 9:26 ` Greg KH
2020-07-27 10:03 ` Forest Crossman
2020-07-27 10:12 ` Greg KH
2020-07-27 9:06 ` [PATCH 2/2] usb: xhci: Fix ASMedia ASM1142 DMA addressing Forest Crossman
2020-07-28 4:24 ` [PATCH v2 0/2] Small fixes for ASMedia host controllers Forest Crossman
2020-07-28 4:24 ` [PATCH v2 1/2] usb: xhci: define IDs for various " Forest Crossman
2020-07-29 18:08 ` Sergei Shtylyov [this message]
2020-07-28 4:24 ` [PATCH v2 2/2] usb: xhci: Fix ASMedia ASM1142 DMA addressing Forest Crossman
2020-07-28 11:16 ` [PATCH v2 0/2] Small fixes for ASMedia host controllers Greg KH
2020-07-28 12:40 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbfff9a-e64e-e11f-c032-2bbbb7359c97@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=cyrozap@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).