From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8AAC54EBD for ; Thu, 12 Jan 2023 09:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239524AbjALJI7 (ORCPT ); Thu, 12 Jan 2023 04:08:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235894AbjALJIT (ORCPT ); Thu, 12 Jan 2023 04:08:19 -0500 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCB44FD62; Thu, 12 Jan 2023 01:03:36 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CEDB85C018C; Thu, 12 Jan 2023 04:03:35 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 12 Jan 2023 04:03:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673514215; x=1673600615; bh=z28MIn97Rc 98zMcl0IlmdYkFgGOJRGV34Y2wLplLgGI=; b=DDe1bwierpKaunxk71CoGT6yzi SJedgNQ/YlAe+TGcKid1qsvbyAjbCv4saHqU3wjPfsX2JwUXMfVdJPXIe7+C1dSW jdh8iYLPBBZ1fLELXkb9Q0QXd5m/rq5R/gYNEdzaVuwr90laSj2jslbVJEKIYVpM rJ2w99HKM4Pk8VhElkdG+wWkQ1ld3xPVU4MweQtnZhCXA/YIfwI+lDn23Q90rV3p x/vhrNl2yKcZ31u1VaPlZthYyrOuM6gGs56oyMv8UiWtSXE8OYTcgTxS0QSh44C7 OJKFX37rgTInHCnbKBeT/CzyMaaSzXJTLy8Nq0bQwL6VZWRhZSusVbWJ57lw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673514215; x=1673600615; bh=z28MIn97Rc98zMcl0IlmdYkFgGOJ RGV34Y2wLplLgGI=; b=E4t3NR5k0rfwB6JFxnkLIK1/WIvewfETzb2a3egUsRbP YKgjGSCg+KjN4Ho1L+xRbjDaqpzrr275xA66CQD7vV86jcG4JtFjqMfBUY05R+wd NiXD0aaSHsLOdG5GWYJvfrZqXCpoglTcyuqZ3U9YQgJhbrF+RhxORtYtLSfOz+Rk lF1g8OXKAOuzIs/CZJhyUQdV2EuM5FwOv3m8sZ67bbhoWRG286ioYPduOGEyCxc0 L9IvrP26O4kqfFVkePtlbHkHffeZEEKzb9hS22xDLIJFofxiopmlfcTua3xLDGkS /mr2UpHbGMKp3CpJ2EDjKaoMUrqgPoBUFNIfgC+mow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleehgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 32133B60089; Thu, 12 Jan 2023 04:03:35 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <3f2663ff-ff3f-4632-853a-ba4d38df9701@app.fastmail.com> In-Reply-To: <20230112083746.9551-4-lukas.bulwahn@gmail.com> References: <20230112083746.9551-1-lukas.bulwahn@gmail.com> <20230112083746.9551-4-lukas.bulwahn@gmail.com> Date: Thu, 12 Jan 2023 10:02:50 +0100 From: "Arnd Bergmann" To: "Lukas Bulwahn" Cc: "Aaro Koskinen" , "Janusz Krzysztofik" , "Tony Lindgren" , "Krzysztof Kozlowski" , linux-arm-kernel@lists.infradead.org, Linux-OMAP , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] usb: remove OMAP USB Device Controller and OHCI support for OMAP1/2 chips Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote: > Commit 0fee2eac5c2b ("usb: phy: remove phy-isp1301-omap driver") removes > the Philips ISP1301 with OMAP OTG driver and its corresponding config > ISP1301_OMAP. The drivers, OMAP USB Device Controller and OHCI support for > OMAP1/2 chips, with corresponding configs, USB_OMAP and USB_OHCI_HCD_OMAP1, > need this removed driver (see "depends on ISP1301_OMAP") to build. > > Remove those two drivers. > > With the config USB_OMAP removed in this commit, remove some further code > in the omap-dma header and mach-omap1 architecture code. > > Signed-off-by: Lukas Bulwahn This would be a great cleanup because of the simplications of the omap-dma code. I had previously looked at it and concluded that the driver is still in use though, and I think my mistake was just in the Kconfig part of this patch: commit c32fd10914a314dd96c5d24030200070c84df5f1 Author: Arnd Bergmann Date: Thu Sep 29 15:38:56 2022 +0200 ARM: omap1: remove unused board files All board support that was marked as 'unused' earlier can now be removed, leaving the five machines that that still had someone using them in 2022, or that are supported in qemu. Cc: Aaro Koskinen Cc: Janusz Krzysztofik Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org Signed-off-by: Arnd Bergmann diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index b3006d8b04ab..95751062078e 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -118,7 +118,7 @@ config USB_GR_UDC config USB_OMAP tristate "OMAP USB Device Controller" depends on ARCH_OMAP1 - depends on ISP1301_OMAP || !(MACH_OMAP_H2 || MACH_OMAP_H3) + depends on ISP1301_OMAP help Many Texas Instruments OMAP processors have flexible full speed USB device controllers, with support for up to 30 diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 0442dc4bc334..a0c14c62ff32 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -409,7 +409,7 @@ if USB_OHCI_HCD config USB_OHCI_HCD_OMAP1 tristate "OHCI support for OMAP1/2 chips" depends on ARCH_OMAP1 - depends on ISP1301_OMAP || !(MACH_OMAP_H2 || MACH_OMAP_H3) + depends on ISP1301_OMAP default y help Enables support for the OHCI controller on OMAP1/2 chips. Instead of changing this to 'depends on ISP1301_OMAP', the line probably should just be dropped entirely. Arnd