public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Sebastian Reichel <sre@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-pm@vger.kernel.org,
	RD Babiera <rdbabiera@google.com>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM
Date: Sun, 16 Mar 2025 17:52:10 +0100	[thread overview]
Message-ID: <3f65fe16-56f8-4887-bb91-994b181ce5a9@kernel.org> (raw)
In-Reply-To: <914a0df4-96d0-4cd4-ac87-3826fa9c1440@google.com>

On 15/03/2025 01:49, Amit Sunil Dhamne wrote:
> Hi Krzysztof,
> 
> Thanks for the review!
> 
> On 3/13/25 1:50 AM, Krzysztof Kozlowski wrote:
>> On Wed, Mar 12, 2025 at 04:42:00PM -0700, Amit Sunil Dhamne wrote:
>>> Support for Battery Status & Battery Caps messages in response to
>>> Get_Battery_Status & Get_Battery_Cap request is required by USB PD devices
>>> powered by battery, as per "USB PD R3.1 V1.8 Spec", "6.13 Message
>>> Applicability" section. This patchset adds support for these AMSes
>>> to achieve greater compliance with the spec.
>> Which board uses it? I would be happy to see that connection between
>> batteries and USB connector on the schematics of some real device. How
>> does it look like?
> Any board that uses a USB Type-C connector that supplies power into or 

If you keep responding like this, you will got nowhere, so let me
re-iterate:

Which upstream DTS (or upstream supported hardware) is going to use this
binding, so I can see how you are going to implement it there in the
entire system?

> out of a battery while operating in sink or source mode respectively. 
> The VBUS is connected to the (battery + buck boost IC's CHGin/Vin) or a 
> companion IFPMIC connected to a battery.  In our board we have USB 
> Connector <-> IFPMIC <-> Battery.

Which board is that?

Best regards,
Krzysztof

  reply	other threads:[~2025-03-16 16:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 23:42 [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM Amit Sunil Dhamne via B4 Relay
2025-03-12 23:42 ` [PATCH 1/5] dt-bindings: connector: add fixed-batteries property Amit Sunil Dhamne via B4 Relay
2025-03-13  8:48   ` Krzysztof Kozlowski
2025-03-15  0:56     ` Amit Sunil Dhamne
2025-03-16 16:49       ` Krzysztof Kozlowski
2025-03-20 19:49         ` Amit Sunil Dhamne
2025-03-16 16:55       ` Krzysztof Kozlowski
2025-03-20 19:45         ` Amit Sunil Dhamne
2025-03-12 23:42 ` [PATCH 2/5] power: supply: core: add function to get supplies from fwnode Amit Sunil Dhamne via B4 Relay
2025-03-19 13:54   ` Heikki Krogerus
2025-04-08 19:54     ` Amit Sunil Dhamne
2025-03-12 23:42 ` [PATCH 3/5] usb: typec: tcpm: Add support for Battery Status response message Amit Sunil Dhamne via B4 Relay
2025-03-12 23:42 ` [PATCH 4/5] power: supply: core: add vendor and product id properties Amit Sunil Dhamne via B4 Relay
2025-03-12 23:42 ` [PATCH 5/5] usb: typec: tcpm: Add support for Battery Cap response message Amit Sunil Dhamne via B4 Relay
2025-03-13  8:50 ` [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM Krzysztof Kozlowski
2025-03-15  0:49   ` Amit Sunil Dhamne
2025-03-16 16:52     ` Krzysztof Kozlowski [this message]
2025-03-20 21:11       ` Amit Sunil Dhamne
2025-03-21  7:51         ` Krzysztof Kozlowski
2025-04-03  3:41           ` Amit Sunil Dhamne
2025-04-03  8:00             ` Krzysztof Kozlowski
2025-04-03  8:02               ` Krzysztof Kozlowski
2025-04-08 19:50                 ` Amit Sunil Dhamne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f65fe16-56f8-4887-bb91-994b181ce5a9@kernel.org \
    --to=krzk@kernel.org \
    --cc=amitsd@google.com \
    --cc=badhri@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=kyletso@google.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rdbabiera@google.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox