From: Oliver Neukum <oneukum@suse.com>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
Oliver Neukum <oneukum@suse.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Rhett Aultman <rhett.aultman@samsara.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-can <linux-can@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [RFC PATCH] USB: core: urb: add new transfer flag URB_FREE_COHERENT
Date: Tue, 7 Jun 2022 13:46:26 +0200 [thread overview]
Message-ID: <409f73a8-8679-61ff-4da6-018833c7a96d@suse.com> (raw)
In-Reply-To: <CAMZ6Rq+CtOQ7Gn62QQqDd=_0dvCNhh5g_oXB6LmHEd0MfRym1g@mail.gmail.com>
On 07.06.22 12:18, Vincent MAILHOL wrote:
> Here the proposed solution was to keep a pointer of all the
> transfer_buffer in a local array to be able to free them when closing.
> I really found that original patch to be unelegant which led me to
> propose this RFC.
It was.
> Comparatively, I still think my patch to be a more elegant solution,
> and the original author also seems to share my thoughts.
>
> If my patch is unelegant, then what would be the elegant/state of the
> art way to free all this DMA allocated memory?
> (pointing to any reference driver implementation should be enough for
> me to understand).
I have two options to offer.
1. Use the existing URB_NO_TRANSFER_D;MA_MAP to decide
how to free memory.
2. Provide an explicit API in usbcore among the anchor API
Regards
Oliver
next prev parent reply other threads:[~2022-06-07 11:46 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.22.394.2206031547001.1630869@thelappy>
2022-06-04 2:11 ` [PATCH] can: gs_usb: gs_usb_open/close( ) fix memory leak Vincent Mailhol
2022-06-04 2:26 ` Vincent MAILHOL
2022-06-04 14:08 ` Rhett Aultman
2022-06-04 14:41 ` [RFC PATCH] USB: core: urb: add new transfer flag URB_FREE_COHERENT Vincent Mailhol
2022-06-04 16:40 ` Alan Stern
2022-06-05 2:04 ` Vincent MAILHOL
2022-06-05 6:00 ` Oliver Neukum
2022-06-05 13:45 ` Vincent MAILHOL
2022-06-07 9:49 ` Oliver Neukum
2022-06-07 10:18 ` Vincent MAILHOL
2022-06-07 11:46 ` Oliver Neukum [this message]
2022-06-07 12:12 ` Vincent MAILHOL
2022-06-05 2:15 ` [RFC PATCH v2] usb: " Vincent Mailhol
2022-06-04 14:53 ` [PATCH] can: gs_usb: gs_usb_open/close( ) fix memory leak Vincent MAILHOL
2022-06-09 20:47 ` [PATCH v2 0/3] URB_FREE_COHERENT gs_usb memory leak fix Rhett Aultman
2022-06-09 20:47 ` [PATCH v2 1/3] drivers: usb/core/urb: Add URB_FREE_COHERENT Rhett Aultman
2022-06-10 0:18 ` Vincent MAILHOL
2022-06-10 10:46 ` Marc Kleine-Budde
2022-06-09 20:47 ` [PATCH v2 2/3] drivers: usb/core/urb: allow URB_FREE_COHERENT Rhett Aultman
2022-06-09 23:18 ` Vincent Mailhol
2022-06-09 20:47 ` [PATCH v2 3/3] can: gs_usb: fix DMA memory leak on close Rhett Aultman
2022-06-10 0:05 ` Vincent Mailhol
2022-06-10 1:28 ` Vincent Mailhol
2022-06-10 21:33 ` [PATCH v3 0/2] URB_FREE_COHERENT gs_usb memory leak fix Rhett Aultman
2022-06-10 21:33 ` [PATCH v3 1/2] drivers: usb/core/urb: Add URB_FREE_COHERENT Rhett Aultman
2022-06-11 15:31 ` Marc Kleine-Budde
2022-06-11 16:06 ` Vincent MAILHOL
2022-06-21 13:51 ` Greg Kroah-Hartman
2022-06-21 14:59 ` Vincent MAILHOL
2022-06-21 15:03 ` Greg Kroah-Hartman
2022-06-21 15:54 ` Vincent MAILHOL
2022-06-21 15:11 ` Alan Stern
2022-06-21 15:55 ` Vincent MAILHOL
2022-06-21 16:14 ` Alan Stern
2022-06-21 16:40 ` Vincent MAILHOL
2022-06-21 17:00 ` Greg Kroah-Hartman
2022-06-21 17:14 ` Vincent MAILHOL
2022-06-21 17:46 ` Greg Kroah-Hartman
2022-06-22 9:22 ` David Laight
2022-06-22 9:41 ` Greg Kroah-Hartman
2022-06-22 10:03 ` David Laight
2022-06-22 11:11 ` Oliver Neukum
2022-06-22 10:34 ` Vincent MAILHOL
2022-06-22 12:23 ` Greg Kroah-Hartman
2022-06-22 15:59 ` Vincent MAILHOL
2022-06-22 18:11 ` Rhett Aultman
2022-06-26 8:21 ` Vincent MAILHOL
2022-06-23 17:30 ` Hongren Zenithal Zheng
2022-06-23 17:45 ` Shuah Khan
2022-06-24 14:43 ` Alan Stern
2022-06-24 16:01 ` Hongren Zenithal Zheng
2022-06-24 16:31 ` Shuah Khan
2022-06-24 18:07 ` Alan Stern
2022-06-27 22:54 ` Shuah Khan
2022-06-28 1:35 ` Alan Stern
2022-07-01 2:10 ` Shuah Khan
2022-08-01 17:42 ` Shuah Khan
2022-08-01 18:28 ` Vincent MAILHOL
2022-08-03 23:44 ` Shuah Khan
2022-06-10 21:33 ` [PATCH v3 2/2] can: gs_usb: fix DMA memory leak on close Rhett Aultman
2022-06-11 15:35 ` Marc Kleine-Budde
2022-06-11 16:03 ` Vincent MAILHOL
2022-06-12 21:28 ` David Laight
2022-06-12 21:33 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409f73a8-8679-61ff-4da6-018833c7a96d@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=rhett.aultman@samsara.com \
--cc=stern@rowland.harvard.edu \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox