From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Neal Liu" <neal_liu@aspeedtech.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Felipe Balbi" <balbi@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Li Yang" <leoyang.li@nxp.com>
Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2 3/3] dt-bindings: usb: add documentation for aspeed udc
Date: Tue, 17 May 2022 14:03:39 +0200 [thread overview]
Message-ID: <414d09f8-328a-4bf4-c20e-f8ce4a6ddfc7@linaro.org> (raw)
In-Reply-To: <20220517082558.3534161-4-neal_liu@aspeedtech.com>
On 17/05/2022 10:25, Neal Liu wrote:
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/aspeed-clock.h>
> + usb: usb@1e6a2000 {
> + compatible = "aspeed,ast2600-udc";
Sorry for not noticing it earlier - slipped through the cracks. You use
here unusual indentation (not matching the rest of the example - above
is 4 spaces, here is 7 or 8).
Just keep 4 spaces for DTS example.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-17 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 8:25 [PATCH v2 0/3] add Aspeed udc driver for ast2600 Neal Liu
2022-05-17 8:25 ` [PATCH v2 1/3] usb: gadget: add Aspeed ast2600 udc driver Neal Liu
2022-05-17 8:25 ` [PATCH v2 2/3] ARM: dts: aspeed: Add USB2.0 device controller node Neal Liu
2022-05-17 11:59 ` Krzysztof Kozlowski
2022-05-17 14:50 ` Neal Liu
2022-05-17 14:53 ` Krzysztof Kozlowski
2022-05-17 15:21 ` Neal Liu
2022-05-17 15:25 ` Krzysztof Kozlowski
2022-05-17 15:32 ` Neal Liu
2022-05-17 8:25 ` [PATCH v2 3/3] dt-bindings: usb: add documentation for aspeed udc Neal Liu
2022-05-17 12:03 ` Krzysztof Kozlowski [this message]
2022-05-17 14:53 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414d09f8-328a-4bf4-c20e-f8ce4a6ddfc7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=christian.koenig@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox