From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-usb@vger.kernel.org
Cc: linux-media@vger.kernel.org, gregkh@linuxfoundation.org,
laurent.pinchart@ideasonboard.com, hdegoede@redhat.com,
Thinh.Nguyen@synopsys.com,
"Amardeep Rai" <amardeep.rai@intel.com>,
"Kannappan R" <r.kannappan@intel.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Michał Pecio" <michal.pecio@gmail.com>
Subject: Re: [PATCH v5 2/9] usb: core: Parse eUSB2 companion descriptors for high speed devices only
Date: Tue, 26 Aug 2025 15:50:56 +0300 [thread overview]
Message-ID: <419e2484-53e9-456e-a78f-87a73ed042c1@linux.intel.com> (raw)
In-Reply-To: <20250820143824.551777-3-sakari.ailus@linux.intel.com>
On 20.8.2025 17.38, Sakari Ailus wrote:
> Check that a device is a high-speed one before proceeding to parse the
> eUSB2 isochronous endpoint companion descriptors.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/usb/core/config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index cda595b4014f..29fcbd6de482 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -507,7 +507,8 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
> }
>
> /* Parse a possible eUSB2 periodic endpoint companion descriptor */
> - if (bcdUSB == 0x0220 && !le16_to_cpu(d->wMaxPacketSize) &&
> + if (udev->speed == USB_SPEED_HIGH && bcdUSB == 0x0220 &&
> + !le16_to_cpu(d->wMaxPacketSize) &&
> (usb_endpoint_xfer_isoc(d) || usb_endpoint_xfer_int(d)))
> usb_parse_eusb2_isoc_endpoint_companion(ddev, cfgno, inum, asnum,
> endpoint, buffer, size);
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
next prev parent reply other threads:[~2025-08-26 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 14:38 [PATCH v5 0/9] eUSB2 Double Isochronous IN Bandwidth support Sakari Ailus
2025-08-20 14:38 ` [PATCH v5 1/9] usb: core: Use le16_to_cpu() to read __le16 value in usb_parse_endpoint() Sakari Ailus
2025-08-26 12:50 ` Mathias Nyman
2025-08-20 14:38 ` [PATCH v5 2/9] usb: core: Parse eUSB2 companion descriptors for high speed devices only Sakari Ailus
2025-08-26 12:50 ` Mathias Nyman [this message]
2025-08-20 14:38 ` [PATCH v5 3/9] usb: core: eUSB2 companion descriptor is for isoc IN endpoints only Sakari Ailus
2025-08-26 12:52 ` Mathias Nyman
2025-08-20 14:38 ` [PATCH v5 4/9] usb: core: Add a function to get USB version independent periodic payload Sakari Ailus
2025-08-20 14:38 ` [PATCH v5 5/9] usb: xhci: Use usb_endpoint_max_periodic_payload() Sakari Ailus
2025-08-21 8:22 ` Mathias Nyman
2025-08-20 14:38 ` [PATCH v5 6/9] usb: core: Introduce usb_endpoint_is_hs_isoc_double() Sakari Ailus
2025-08-26 12:53 ` Mathias Nyman
2025-08-20 14:38 ` [PATCH v5 7/9] usb: xhci: Add host support for eUSB2 double isochronous bandwidth devices Sakari Ailus
2025-08-20 14:38 ` [PATCH v5 8/9] usb: core: support eUSB2 double bandwidth large isoc URB frames Sakari Ailus
2025-08-20 14:38 ` [PATCH v5 9/9] media: uvcvideo: eUSB2 double isochronous bandwidth support Sakari Ailus
2025-08-20 15:21 ` Ricardo Ribalda
2025-08-21 9:51 ` Sakari Ailus
2025-08-26 13:28 ` [PATCH v5 0/9] eUSB2 Double Isochronous IN Bandwidth support Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419e2484-53e9-456e-a78f-87a73ed042c1@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=amardeep.rai@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=r.kannappan@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).