From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9BCC3090D5 for ; Tue, 24 Mar 2026 21:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774388048; cv=none; b=HIQMn9jjkNTmJlThrgZt5xFS8AcbsLi+rB1SJamuXcpc/nh5QPtFGOTIf2YE15iyRISwW9vc+soDGlNyWhm2KGryfeyVOYruSjX4djWQCENSYsWTbd87jCd++dm2Q5P7uTPPHask/OaOb7WSperjDsMxwGJJpRDX+luSQI5UxUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774388048; c=relaxed/simple; bh=MUgBHrSd5Eaisetn5rk18NYLq0bGtPJN237wYHa4aBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PkOj+yMJZ6Ddoa8FRKretROet0tld+K5z+R+OoC2uM+Qk1tdrX8TMGOuDQ8kcthZdn6gGrCYdiSMCdPEjyC3f6BigHYHEQXi+3dVc28gvK0zWUyYUepbINXOWCUQsqB5/nt30RyUlvZmN+WknyQYaUI0kfAyWo1NhXt8QnQIa4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NkyS8+Km; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NkyS8+Km" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7d86eb7c854so1878301a34.3 for ; Tue, 24 Mar 2026 14:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1774388046; x=1774992846; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IuvaKH6SCR9+aNoGoEjXACsCakxFP7F2n123rgDmZ5g=; b=NkyS8+Km4Bp6ENH29lwm7JmioAIzHruF2duTKrGnJyRFZ97DFg6MRS2W31ms78FsON FcmUbWgmoC/huO4VPJ8lPZxpGZ8t4LuKI9mMElGWXxcxrFhqpah2nFCso1A4eGvjOi71 9AUBPqvH9Lpo0mBXiiK0dryHMq9G5a6n3C4iY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774388046; x=1774992846; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IuvaKH6SCR9+aNoGoEjXACsCakxFP7F2n123rgDmZ5g=; b=FFkaecmawhhY5IEr0rnhua/mO+6VYPhFSGjzekcJ8PalFjJbr8YzGKUKxMxly9pPnb KiLC25usOY1US4vrs6di3/Aw91dMbYyoFln0g6R0dX+ywgvgByE0e2+DQPOJ6wvhL+pq s2706MoFrbNo0kh+7pSRAp6v/YTyEexKj/OujKWzHLxMrpA8CdFBdYH7UTuWy6KXcehy QdQA9SvE+gbyhIPk2ZM7+POhismKdC/fvoM6RzdtMOeRGl4ecQm779MHuNy5GTOScUQE 8FbxDF5fofXTv+7R0bM6EA4HN8s3aIZ6fFrn0VhyTZt6hfP2g1eWfuMyZCl82pGz6FQo eTCg== X-Forwarded-Encrypted: i=1; AJvYcCXUspZKXqFlIwuQEbenIS1jseNEXAUAX6eGQX/gJ0p4WuHWpqjRZq+WAOVwqcigUWsIsHZFsDK/uWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5RTaQiIQkr/Mu475tzzv4O10iPG1w9WdT9cQUl4YARy3j3rFX 0qcP3vUWb2YZZ5MT26aXp3U0JuFKmhG8WuNn0VfUhHCk4ZSjB5hdftOeFPhX9UWYXjs= X-Gm-Gg: ATEYQzxMyNsUFTZSdWlKPs0iWw6gKR+zXa8ehLgEQrOMZ8wG4Vg7p/qoI/tELBR5v8d fxTwV0GqR+RLMmXn0TskHf0ShPAPcCQtGdtXEdJ2wS8e12uu9h0YSlONY5x5INpGhwjvSvonxV9 07UXj5gK7HAltX8qGfSZjr+c0TG1AlqCiDfZC2BD5uAmlcUNGhaenNGzIdcR0qVHzJYMpd1W7JD 9yiL63+eX1hVMZF5OEXGXsBr423VCN/BdqulsoiRdRodGbDNSQ11auT69bFTBP81bTACxcSYTlE awtmXa7zecV+LN304BTLfOugAWc37/t3PIrWSkLoljReTkXkiv8CABTFFXTolnnayNvCxwzgA9T +XsjRXwVQNHdDPyInKg0MRVLGJ5bvnsy9v5JrJGWVxi8Q+SxrnMlRuZ1Ee8IyREO8XUj5bqcMWS Arb/roC9z5YZmiK24KejujDJXZ5ATLIW/zlsI= X-Received: by 2002:a05:6820:6ac7:b0:67b:ddec:e4c1 with SMTP id 006d021491bc7-67dff5c3e0emr696531eaf.69.1774388045950; Tue, 24 Mar 2026 14:34:05 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-67c252c892dsm9157301eaf.4.2026.03.24.14.34.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 14:34:05 -0700 (PDT) Message-ID: <4328a59a-a02b-491f-92a5-4dbd10ee77c2@linuxfoundation.org> Date: Tue, 24 Mar 2026 15:34:03 -0600 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] usbip: vhci_sysfs: Use safer strscpy() instead of strcpy() To: Dan Carpenter Cc: Ai Chao , gregkh@linuxfoundation.org, b-liu@ti.com, johan@kernel.org, badhri@google.com, heikki.krogerus@linux.intel.com, valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me, tiwai@suse.de, kees@kernel.org, christophe.jaillet@wanadoo.fr, prashanth.k@oss.qualcomm.com, khtsai@google.com, tglx@kernel.org, mingo@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260310094434.3639602-1-aichao@kylinos.cn> <20260310094434.3639602-7-aichao@kylinos.cn> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/11/26 01:22, Dan Carpenter wrote: > On Tue, Mar 10, 2026 at 04:10:20PM -0600, Shuah Khan wrote: >> On 3/10/26 03:44, Ai Chao wrote: >>> Use a safer function strscpy() instead of strcpy() for copying to >>> arrays. >>> >>> Only idiomatic code replacement, and no functional changes. >> >> It is a functional change since it calls a new routine. Get rid >> of this line from change log. >> >> How did you test this patch? I am curious because of you are >> describing the change as "idiomatic code replacement" >> > > I liked the commit message... To me it says that patch affect > runtime. It doesn' fix any bugs or introduce any bugs. Too often > these changes are sold as a "potential" bugfix, which means people > haven't bothered to check whether it fixes a bug or not. > > It's the right thing to add a note under the --- cut off that the > patch hasn't been tested. Testing isn't required for this sort > of patch but a note is good so reviewers will know to be careful. I would like to see some sort of testing for patches like this one. It isn't hard to test this change. thanks, -- Shuah