public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akash Kumar <quic_akakum@quicinc.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jack Pham <quic_jackp@quicinc.com>,
	kernel@oss.qualcomm.com, Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vijayavardhan Vennapusa <quic_vvreddy@quicinc.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/18] Reserve high bandwidth for HS isoc eps
Date: Mon, 10 Feb 2025 09:22:23 +0100	[thread overview]
Message-ID: <4646aec4-0270-435e-8097-344a1df0e4bc@kernel.org> (raw)
In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com>

On 06/02/2025 12:15, Akash Kumar wrote:
> It is observed while testing multiple audio devices over usb, a glitch is
> observed during testing. As per dwc datasheet,By default, HC reserves 80%
> of the bandwidth for periodic EPs which can be increased if needed.
> 
> Add quirk to set GUCTL register BIT 16 to accommodate higher bandwidth for
> 2 isoc eps.
> 
> If this bit is set, the bandwidth is relaxed to 85% to accommodate two high
> speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated
> for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are
> connected, and if each requires 1024-bytes X 3 packets per Micro-Frame,
> then the bandwidth required is around 82%. If this bit is set, then it is
> possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame
> each. Alternatively, you might need to lower the resolution of the
> webcams. This bit is valid in Host and DRD configuration and is used in
> host mode operation only.
> 
> Set this bit for host mode uvc uac usecases where two isoc eps are used
> and uvc flickers or audio glitch is observed.
> 
> Akash Kumar (18):
>   usb: dwc3: Reserve Higher Bandwidth for HS Periodic EPs
>   arm64: dts: qcom: sa8775p: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm8350: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm8450: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm8150: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm6125: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm8250: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sm6350: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sc7280: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sdm630: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sdm845: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sdx75: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: qcs404: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sc7180: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: x1e80100: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sc8280xp: Enable high bandwidth for hs isoc eps
>   arm64: dts: qcom: sc8180x: Enable high bandwidth for hs isoc eps

1. Do not combine USB and DTS in one patchset.
2. This was not ever tested (see bug reports already published by bot),
so obviously disappointing no-go.
3. This looks like SoC specific, so deduce the setting from the compatible.


Best regards,
Krzysztof

  parent reply	other threads:[~2025-02-10  8:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 11:15 [PATCH 00/18] Reserve high bandwidth for HS isoc eps Akash Kumar
2025-02-06 11:15 ` [PATCH 01/18] usb: dwc3: Reserve Higher Bandwidth for HS Periodic EPs Akash Kumar
2025-02-06 17:49   ` Konrad Dybcio
2025-02-10  8:16     ` AKASH KUMAR
2025-02-10  8:19   ` Krzysztof Kozlowski
2025-02-06 11:15 ` [PATCH 02/18] arm64: dts: qcom: sa8775p: Enable high bandwidth for hs isoc eps Akash Kumar
2025-02-06 11:15 ` [PATCH 03/18] arm64: dts: qcom: sm8350: " Akash Kumar
2025-02-06 11:15 ` [PATCH 04/18] arm64: dts: qcom: sm8450: " Akash Kumar
2025-02-06 11:15 ` [PATCH 05/18] arm64: dts: qcom: sm8150: " Akash Kumar
2025-02-06 11:15 ` [PATCH 06/18] arm64: dts: qcom: sm6125: " Akash Kumar
2025-02-06 11:15 ` [PATCH 07/18] arm64: dts: qcom: sm8250: " Akash Kumar
2025-02-06 11:15 ` [PATCH 08/18] arm64: dts: qcom: sm6350: " Akash Kumar
2025-02-06 11:15 ` [PATCH 09/18] arm64: dts: qcom: sc7280: " Akash Kumar
2025-02-06 11:15 ` [PATCH 10/18] arm64: dts: qcom: sdm630: " Akash Kumar
2025-02-06 11:15 ` [PATCH 11/18] arm64: dts: qcom: sdm845: " Akash Kumar
2025-02-06 11:15 ` [PATCH 12/18] arm64: dts: qcom: sdx75: " Akash Kumar
2025-02-06 11:15 ` [PATCH 13/18] arm64: dts: qcom: qcs404: " Akash Kumar
2025-02-06 11:15 ` [PATCH 14/18] arm64: dts: qcom: sc7180: " Akash Kumar
2025-02-06 11:15 ` [PATCH 15/18] arm64: dts: qcom: x1e80100: " Akash Kumar
2025-02-06 11:15 ` [PATCH 16/18] arm64: dts: qcom: " Akash Kumar
2025-02-06 11:15 ` [PATCH 17/18] arm64: dts: qcom: sc8280xp: " Akash Kumar
2025-02-06 11:15 ` [PATCH 18/18] arm64: dts: qcom: sc8180x: " Akash Kumar
2025-02-07 15:21 ` [PATCH 00/18] Reserve high bandwidth for HS " Rob Herring (Arm)
2025-02-10  8:22 ` Krzysztof Kozlowski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-06 11:10 Akash Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4646aec4-0270-435e-8097-344a1df0e4bc@kernel.org \
    --to=krzk@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_akakum@quicinc.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_vvreddy@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox