Re: [PATCH 01/18] usb: dwc3: Reserve Higher Bandwidth for HS Periodic EPs

Krzysztof Kozlowski
2025-02-10T08:20:01Z

On 06/02/2025 12:15, Akash Kumar wrote:
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index dfa1b5fe48dc..7e55c234e4e5 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1461,6 +1461,14 @@ static int dwc3_core_init(struct dwc3 *dwc)
> dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
> }
>
> + if (dwc->revision >= DWC3_REVISION_250A) {
> + if (dwc->dwc3_guctl_resbwhseps_quirk) {
> + reg = dwc3_readl(dwc->regs, DWC3_GUCTL);
> + reg |= DWC3_GUCTL_RESBWHSEPS;
> + dwc3_writel(dwc->regs, DWC3_GUCTL, reg);
> + }
> + }
> +
> dwc3_config_threshold(dwc);
>
> /*
> @@ -1818,6 +1826,9 @@ static void dwc3_get_properties(struct dwc3 *dwc)
> dwc->dis_split_quirk = device_property_read_bool(dev,
> "snps,dis-split-quirk");
>
> + dwc->dwc3_guctl_resbwhseps_quirk = device_property_read_bool(dev,
> + "snps,dwc3_guctl_resbwhseps_quirk");

NAK, undocumented ABI, not even bothering to follow standard DTS coding
style.

Best regards,
Krzysztof