From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC88C433EF for ; Fri, 24 Jun 2022 06:43:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbiFXGnZ (ORCPT ); Fri, 24 Jun 2022 02:43:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiFXGnV (ORCPT ); Fri, 24 Jun 2022 02:43:21 -0400 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3592444746; Thu, 23 Jun 2022 23:43:20 -0700 (PDT) Received: from ip6-localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 25O6dolY023080; Fri, 24 Jun 2022 01:39:51 -0500 Message-ID: <46f88070d8f6f47f55310e964a4576cadbc810f4.camel@kernel.crashing.org> Subject: Re: [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0 From: Benjamin Herrenschmidt To: Dan Carpenter Cc: "neal_liu@aspeedtech.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , "balbi@kernel.org" Date: Fri, 24 Jun 2022 16:39:50 +1000 In-Reply-To: <20220624063457.GG11460@kadam> References: <20220623064320.GN16517@kadam> <20220624063457.GG11460@kadam> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org (switching back to my normal "community" email) On Fri, 2022-06-24 at 09:34 +0300, Dan Carpenter wrote: > > Hrm... what is that driver ? I've missed it ... is the code lifted > > from > > aspeed-vhub ? If yes, should we instead make it a common code base > > ? > > And if there are bug fixes on one they might apply to the other as > > well... > > > No, I'm the person who introduced the bug so it's unique to this > driver. Ok thanks. That said, the code looks fairly similar to the vhub code, so my comment stands, if this is the same IP block, which it appears to be, the driver should be common. IE. The vhub is made of a virtual hub with a bunch of UDCs underneath, this appears to address the ast2600 "new" standalone (no hub) variant of said UDC if I'm not mistaken. The way I structured the code in vhub, it shouldn't be overly difficult to make it standalone. I wrote (and maintain) aspeed-vhub and would be happy to work on this if I got sent an ast2600 board. Cheers, Ben.