From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Oliver Neukum <oneukum@suse.com>, Rick Tseng <rtseng@nvidia.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: wait CNR when doing xhci resume
Date: Tue, 13 Aug 2019 13:39:19 +0300 [thread overview]
Message-ID: <47f0e5d6-145c-4542-362f-dbb4cccb514d@linux.intel.com> (raw)
In-Reply-To: <1565597989.14671.3.camel@suse.com>
On 12.8.2019 11.19, Oliver Neukum wrote:
> Am Montag, den 12.08.2019, 15:24 +0800 schrieb Rick Tseng:
>> From: Rick <rtseng@nvidia.com>
>>
>> NVIDIA 3.1 xHCI card would lose power when moving power state into D3Cold.
>> Thus we need to wait CNR bit to clear when xhci resmue as xhci init.
>
> Should any controller have CNR set? Why is this specific to a vendor?
>
Good point, always checking CNR in resume sounds like a good idea.
And use xhci_handshake() as Felipe pointed out, just like in xhci_reset():
ret = xhci_handshake(&xhci->op_regs->status, STS_CNR, 0, 10 * 1000 * 1000);
Rick, would you like to write a patch for this?
-Mathias
next prev parent reply other threads:[~2019-08-13 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 7:24 [PATCH] xhci: wait CNR when doing xhci resume Rick Tseng
2019-08-12 8:12 ` Felipe Balbi
2019-08-12 8:19 ` Oliver Neukum
2019-08-13 10:39 ` Mathias Nyman [this message]
2019-08-13 12:33 ` Rick Tseng
2019-08-13 12:36 ` Felipe Balbi
2019-08-13 13:12 ` Mathias Nyman
2019-08-12 13:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f0e5d6-145c-4542-362f-dbb4cccb514d@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.com \
--cc=rtseng@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).