Linux USB
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal
Date: Thu, 12 Jan 2023 10:05:47 +0100	[thread overview]
Message-ID: <4d2f2b81-b7ab-4ad6-84cc-f3a3c932880d@app.fastmail.com> (raw)
In-Reply-To: <20230112083746.9551-3-lukas.bulwahn@gmail.com>

On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote:
> Commit 150ccb6f9a89 ("ARM: pxa: remove pxa93x support") removes configs
> CPU_PXA930 and CPU_PXA935 and uses of cpu_is_pxa93x() and cpu_is_pxa935().
>
> Remove some further dead code in ./include/linux/soc/pxa/cpu.h on top of
> that commit above.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

I had this in an earlier version and ended up leaving this bit in
when I reworked the series to not drop support for PXA310 and PXA320.

You are probably right that we should not reference the removed
Kconfig symbols, but I see that this causes a regression
unless I also bring back the change to

drivers/mmc/host/pxamci.c:                              || cpu_is_pxa935())

    Arnd

  reply	other threads:[~2023-01-12  9:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  8:37 [PATCH 0/4] Further code removal after Arnd's latest cleanup Lukas Bulwahn
2023-01-12  8:37 ` [PATCH 1/4] ARM: s3c: remove obsolete s3c-cpu-freq header Lukas Bulwahn
2023-01-12  8:57   ` Krzysztof Kozlowski
2023-01-12  8:37 ` [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal Lukas Bulwahn
2023-01-12  9:05   ` Arnd Bergmann [this message]
2023-01-12  9:26     ` Lukas Bulwahn
2023-01-12 10:30       ` Arnd Bergmann
2023-01-12  8:37 ` [PATCH 3/4] usb: remove OMAP USB Device Controller and OHCI support for OMAP1/2 chips Lukas Bulwahn
2023-01-12  9:02   ` Arnd Bergmann
2023-01-12  9:19     ` Lukas Bulwahn
2023-01-12  9:53       ` Arnd Bergmann
2023-01-12  9:53     ` Tony Lindgren
2023-01-12 10:19       ` Arnd Bergmann
2023-01-12 14:05         ` Aaro Koskinen
2023-01-12 14:31           ` Arnd Bergmann
2023-01-13  7:14             ` Tony Lindgren
2023-01-12  8:37 ` [PATCH 4/4] ARM: debug: remove references in DEBUG_UART_8250_SHIFT to removed configs Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d2f2b81-b7ab-4ad6-84cc-f3a3c932880d@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=aaro.koskinen@iki.fi \
    --cc=jmkrzyszt@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox