Linux USB
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: George Moussalem <george.moussalem@outlook.com>,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
Subject: Re: [PATCH 7/9] arm64: dts: qcom: ipq6018: Flatten usb controller nodes
Date: Tue, 1 Sep 2026 17:24:47 +0200	[thread overview]
Message-ID: <4d96c593-ff1b-48f7-9e33-ded415056f99@oss.qualcomm.com> (raw)
In-Reply-To: <SN7PR19MB67361579E71DBC197E21F44E9DAA2@SN7PR19MB6736.namprd19.prod.outlook.com>

On 8/30/26 5:12 AM, George Moussalem wrote:
> On 8/29/26 20:48, Krishna Kurapati wrote:
>>
>>
>> On 8/25/2026 4:12 PM, George Moussalem via B4 Relay wrote:
>>> From: George Moussalem <george.moussalem@outlook.com>
>>>
>>> Flatten usb controller nodes and update to using latest bindings and
>>> flattened driver approach.

[...]

>>> +            tx-fifo-resize;
>>> +            snps,parkmode-disable-ss-quirk;
>>> +            snps,is-utmi-l1-suspend;
>>> +            snps,hird-threshold = /bits/ 8 <0x0>;
>>> +            snps,dis_u2_susphy_quirk;
>>> +            snps,dis_u3_susphy_quirk;
>>> +            dr_mode = "host";
>>
>> This controller is DRD capable. Please move this dr_mode property to DTS
>> file.
> 
> dr_mode was already there. Removing may break existing implementations
> and should require a separate patch.

"Yes" and "yes, please"

Konrad

  reply	other threads:[~2026-09-01 15:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 10:42 [PATCH 0/9] Flatten USB Controller Nodes on IPQ SoCs George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 1/9] dt-bindings: usb: qcom,snps-dwc3: Add ability to select UTMI as reference clock George Moussalem via B4 Relay
2026-08-30  9:41   ` Krzysztof Kozlowski
2026-08-30 13:17     ` George Moussalem
2026-08-31 12:26       ` Krzysztof Kozlowski
2026-08-25 10:42 ` [PATCH 2/9] usb: dwc3: core: Allow glue layer to pass " George Moussalem via B4 Relay
2026-08-30  9:42   ` Krzysztof Kozlowski
2026-09-03  4:57     ` George Moussalem
2026-08-25 10:42 ` [PATCH 3/9] usb: dwc3: qcom: Add support for selecting UTMI as " George Moussalem via B4 Relay
2026-08-26  9:18   ` Konrad Dybcio
2026-08-26  9:37     ` George Moussalem
2026-08-26 10:27       ` Krishna Kurapati
2026-08-27 11:42   ` Varadarajan Narayanan
2026-08-27 11:49     ` George Moussalem
2026-08-25 10:42 ` [PATCH 4/9] arm64: dts: qcom: ipq5018: Flatten usb controller node George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 5/9] arm64: dts: qcom: ipq5332: " George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 6/9] arm64: dts: qcom: ipq5424: Flatten usb controller nodes George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 7/9] arm64: dts: qcom: ipq6018: " George Moussalem via B4 Relay
2026-08-29 16:48   ` Krishna Kurapati
2026-08-30  3:12     ` George Moussalem
2026-09-01 15:24       ` Konrad Dybcio [this message]
2026-08-25 10:42 ` [PATCH 8/9] arm64: dts: qcom: ipq8074: " George Moussalem via B4 Relay
2026-08-29 16:41   ` Krishna Kurapati
2026-08-30  3:14     ` George Moussalem
2026-08-25 10:42 ` [PATCH 9/9] arm64: dts: qcom: ipq9574: Flatten usb controller node George Moussalem via B4 Relay
2026-08-29 16:44   ` Krishna Kurapati
2026-08-30  3:15     ` George Moussalem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d96c593-ff1b-48f7-9e33-ded415056f99@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=george.moussalem@outlook.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    --cc=varadarajan.narayanan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox