From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA4AC04A94 for ; Mon, 14 Aug 2023 07:42:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234236AbjHNHmG (ORCPT ); Mon, 14 Aug 2023 03:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234335AbjHNHl7 (ORCPT ); Mon, 14 Aug 2023 03:41:59 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89511E73 for ; Mon, 14 Aug 2023 00:41:57 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fe4cdb72b9so36358775e9.0 for ; Mon, 14 Aug 2023 00:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691998916; x=1692603716; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=BBL9irmWHTMujcW4M1YOlLfxnMuczJQ+8mOVXEk0MVk=; b=P1iq/wXbOo9batstDzGV9YJzd+25bRwaiWK6awDIC0BZVCTq6Ne82lsk/7vIeDXZA+ 1vDti1FRtCZExgKWGz5fFWlczEQwtema0pHr1L2vCySRLS9DIEwvoRGPs2CmakOLi0JC Gl5AMM894PvoEEcRkVbJfplm/NQfo/LMYT7kFUMlwFcsifvJc9bdbDqb/I1eWNA38fyu 4wu7ZmrvPaoUMEc9o//9Pnavsn8iuX0WDtqufc2T/T3y3YBQPNddnP6yQwdGMpVpyc9N 56ooqAUo7xmTVH1gRb0RX1AGItygrf1MvFO3w7bzVJAE4UHzAe/CZbq1t8w60wiF46g+ v7mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691998916; x=1692603716; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BBL9irmWHTMujcW4M1YOlLfxnMuczJQ+8mOVXEk0MVk=; b=KhcJOVSW/OxZu03r0ths44piwA28ZDyaqvoRlElfICs3YegX6nbxXDW1MbRJHYkbph ktp4T0NHjZq66zdMvESK0IwRl8aN7Et/hkotnmA9zupRDwTkXQs7gaESS9BJjP+Y/Hbn b1gNQ+Q35S85nWOGvK+OnYNsah59OPyNbdrqSFuuT836oejIVFjaN0lS2hCe7MqYfnHN d3Xxn8WJFmdXxUGR1mzKVPpS0KAXlY3iAoUd6T+vt4nf6/YeLhnQwItHlT/hQwwNPlRb GWzeEYcLInx8k0IS2/D56fTRaefwK1yrak8LvdrAtRMfa3IYsJr8APPT29cd/A93Xlng B6+w== X-Gm-Message-State: AOJu0Yx1fyqRmZMl3sG17EGire5u1tIE+It4fysxdnmMIN1vR3451EU0 2pMm9F7V2IDgfbzgpFerwuLT34MUa4rQqVpoX3F7dw== X-Google-Smtp-Source: AGHT+IFIrpJ3pZKR98GY/ZQMj9zHd+SKgxbbYpqvJsQjOEPPpk3/oxMFBr9duPkiu1pVrX0yA9+2uA== X-Received: by 2002:a7b:ce05:0:b0:3fb:ffa8:6d78 with SMTP id m5-20020a7bce05000000b003fbffa86d78mr6531169wmc.36.1691998915875; Mon, 14 Aug 2023 00:41:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:a3d8:b217:d82c:9bc0? ([2a01:e0a:982:cbb0:a3d8:b217:d82c:9bc0]) by smtp.gmail.com with ESMTPSA id z15-20020a1c4c0f000000b003fc0505be19sm13452478wmf.37.2023.08.14.00.41.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 00:41:55 -0700 (PDT) Message-ID: <4de07b08-5eda-86d7-8925-f2fadbfca407@linaro.org> Date: Mon, 14 Aug 2023 09:41:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2] usb: dwc3: meson-g12a: do post init to fix broken usb after resumption Content-Language: en-US To: Luke Lu , linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org Cc: Thinh Nguyen , Greg Kroah-Hartman , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Da Xue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230809212911.18903-1-luke.lu@libre.computer> Organization: Linaro Developer Services In-Reply-To: <20230809212911.18903-1-luke.lu@libre.computer> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 09/08/2023 23:29, Luke Lu wrote: > Device connected to usb otg port of GXL-based boards can not be > recognised after resumption, doesn't recover even if disconnect and > reconnect the device. dmesg shows it disconnects during resumption. > > [ 41.492911] usb 1-2: USB disconnect, device number 3 > [ 41.499346] usb 1-2: unregistering device > [ 41.511939] usb 1-2: unregistering interface 1-2:1.0 > > Calling usb_post_init() will fix this issue, and it's tested and > verified on libretech's aml-s905x-cc board. > > Cc: stable@vger.kernel.org # v5.8+ > Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue") > Signed-off-by: Luke Lu > > --- > Note here, the commmit of Fixes tag is the first patch which bring > suspend/resume function, so let's use it as the fix tag. > > As commit 5b0ba0caaf3a: (usb: dwc3: meson-g12a: refactor usb init)" > introduced the use_post_init() function, and this patch will explicitly > depend on it, so let's set kernel version higher or equal to v5.8. > > Changes since v1: > - add Fixes tag and Cc stable tree > --- > drivers/usb/dwc3/dwc3-meson-g12a.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c > index e99c7489dba0..2c07c038b584 100644 > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -926,6 +926,12 @@ static int __maybe_unused dwc3_meson_g12a_resume(struct device *dev) > return ret; > } > > + if (priv->drvdata->usb_post_init) { > + ret = priv->drvdata->usb_post_init(priv); > + if (ret) > + return ret; > + } > + > return 0; > } > Acked-by: Neil Armstrong