From: Hans de Goede <hdegoede@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Wentong Wu <wentong.wu@intel.com>,
Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: misc: ljca: Fix enumeration error on Dell Latitude 9420
Date: Tue, 21 Nov 2023 19:29:04 +0100 [thread overview]
Message-ID: <4eff7cff-3136-44d0-bf83-0d803122f9da@redhat.com> (raw)
In-Reply-To: <2023112109-talon-atrocious-ad46@gregkh>
Hi,
On 11/21/23 15:05, Greg Kroah-Hartman wrote:
> On Sat, Nov 04, 2023 at 06:51:04PM +0100, Hans de Goede wrote:
>> Not all LJCA chips implement SPI and on chips without SPI reading
>> the SPI descriptors will timeout.
>>
>> On laptop models like the Dell Latitude 9420, this is expected behavior
>> and not an error.
>>
>> Modify the driver to continue without instantiating a SPI auxbus child,
>> instead of failing to probe() the whole LJCA chip.
>>
>> Fixes: 54f225fa5b58 ("usb: Add support for Intel LJCA device")
>
> That commit id isn't in Linus's tree, are you sure it's correct?
Sorry no idea where I got that commit-id from, probably from when
I was carrying the patch in my personal tree for testing it.
I'll send a v3 with the correct commit-id.
Regards,
Hans
prev parent reply other threads:[~2023-11-21 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 17:51 [PATCH v2] usb: misc: ljca: Fix enumeration error on Dell Latitude 9420 Hans de Goede
2023-11-06 5:28 ` Wu, Wentong
2023-11-21 14:05 ` Greg Kroah-Hartman
2023-11-21 18:29 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eff7cff-3136-44d0-bf83-0d803122f9da@redhat.com \
--to=hdegoede@redhat.com \
--cc=andi.shyti@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox