Linux USB
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Michal Pecio <michal.pecio@gmail.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Remove skip_isoc_td()
Date: Mon, 1 Jun 2026 14:07:44 +0300	[thread overview]
Message-ID: <506a9406-91c1-4a1c-9a24-59ef20fd052c@linux.intel.com> (raw)
In-Reply-To: <20260529111002.7621e94b.michal.pecio@gmail.com>

On 5/29/26 12:10, Michal Pecio wrote:
> This function is pointless because usb_submit_urb() initializes all
> isoc frame descriptors to -EXDEV and 0 length so that HCDs don't need
> to do anything with transfers which were never executed.
> 
> Other HCDs rely on this (e.g. EHCI itd_complete()), so we can too.
> This gets rid of a potentially dangereous function which could corrupt
> memory if we weren't super careful to only call it on isoc URBs.
> 
> Also, set status to 0 rather than any random status determined by the
> later TD which caused skipping. This status will be ignored anyway.
> 

Thanks

Adding this as well

-Mathas


      reply	other threads:[~2026-06-01 11:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  9:10 [PATCH] usb: xhci: Remove skip_isoc_td() Michal Pecio
2026-06-01 11:07 ` Mathias Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506a9406-91c1-4a1c-9a24-59ef20fd052c@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=michal.pecio@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox