Linux USB
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Andrzej Hajda <a.hajda@samsung.com>,
	kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Felipe Balbi <felipe.balbi@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC,linux-next] USB: dwc3: dwc3_get_extcon() can be static
Date: Fri, 18 May 2018 10:38:27 +0300	[thread overview]
Message-ID: <50b8c19d-563d-660c-9cf1-134c64062ba8@ti.com> (raw)

On 18/05/18 08:39, Andrzej Hajda wrote:
> On 17.05.2018 18:06, kbuild test robot wrote:
>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> 
> It should be static of course, my bad.
> 
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

I don't think we accept patches from robots, yet :)

> 
>  --
> Regards
> Andrzej
> 
>> ---
>>  drd.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>> index 2706824..218371f 100644
>> --- a/drivers/usb/dwc3/drd.c
>> +++ b/drivers/usb/dwc3/drd.c
>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>  	return NOTIFY_DONE;
>>  }
>>  
>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>  {
>>  	struct device *dev = dwc->dev;
>>  	struct device_node *np_phy, *np_conn;
>>
>>
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

             reply	other threads:[~2018-05-18  7:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  7:38 Roger Quadros [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-18  7:58 [RFC,linux-next] USB: dwc3: dwc3_get_extcon() can be static Roger Quadros
2018-05-18  7:47 Andrzej Hajda
2018-05-18  5:39 Andrzej Hajda
2018-05-17 16:06 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50b8c19d-563d-660c-9cf1-134c64062ba8@ti.com \
    --to=rogerq@ti.com \
    --cc=a.hajda@samsung.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox