Re: [PATCH] USB: OHCI/UHCI: Add soft dependencies on ehci_hcd

["xiao sheng wen(肖盛文)" <atzlinux@sina.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2299 bytes --]

Hi,

在 2025/12/30 16:15, Greg Kroah-Hartman 写道:
> On Tue, Dec 30, 2025 at 04:00:14PM +0800, Huacai Chen wrote:
>> Commit 9beeee6584b9aa4f ("USB: EHCI: log a warning if ehci-hcd is not
>> loaded first") said that ehci-hcd should be loaded before ohci-hcd and
>> uhci-hcd. However, commit 05c92da0c52494ca ("usb: ohci/uhci - add soft
>> dependencies on ehci_pci") only makes ohci-pci/uhci-pci depend on ehci-
>> pci, which is not enough and we may still see the warnings in boot log.
>> So fix it by also making ohci-hcd/uhci-hcd depend on ehci-hcd.
>>
>> Cc: stable@vger.kernel.org
>> Reported-by: Shengwen Xiao <atzlinux@sina.com>
>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
>> ---
>>  drivers/usb/host/ohci-hcd.c | 1 +
>>  drivers/usb/host/uhci-hcd.c | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
>> index 9c7f3008646e..549c965b7fbe 100644
>> --- a/drivers/usb/host/ohci-hcd.c
>> +++ b/drivers/usb/host/ohci-hcd.c
>> @@ -1355,4 +1355,5 @@ static void __exit ohci_hcd_mod_exit(void)
>>  	clear_bit(USB_OHCI_LOADED, &usb_hcds_loaded);
>>  }
>>  module_exit(ohci_hcd_mod_exit);
>> +MODULE_SOFTDEP("pre: ehci_hcd");
> 
> Ick, no, this way lies madness.  I hate the "softdep" stuff, it's
> usually a sign that something is wrong elsewhere.
> 
> And don't add this _just_ to fix a warning message in a boot log, if you
> don't like that message, then build the module into your kernel, right?
In Debian kernel config, the USB driver module is config as module.

I meet this warning info in my Loongarch machine 3A6000 on Debian:

[    1.119467] Warning! ehci_hcd should always be loaded before uhci_hcd and ohci_hcd, not after

I hope this warning can fix in my Loongarch machine.

> 
> And I really should just go revert 05c92da0c524 ("usb: ohci/uhci - add
> soft dependencies on ehci_pci") as well, that feels wrong too.
> 
> thanks,
> 
> greg k-h

Is there more better way to fix this Warning info?


BTW: I'm not a kernel developer, just a Loongarch linux user.

thanks,
-- 
肖盛文 xiao sheng wen -- Debian Developer(atzlinux)
Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40debian.org
GnuPG Public Key: 0x00186602339240CB


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]