public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Niko Mauno <niko.mauno@vaisala.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jaaskelainen Vesa VEJ <vesa.jaaskelainen@vaisala.com>
Subject: Re: [PATCH] usb: core: Make default authorization mode configurable
Date: Fri, 5 Jan 2024 13:56:35 +0200	[thread overview]
Message-ID: <522eb2bb-95d0-4e2f-a426-9347f14f51cb@vaisala.com> (raw)
In-Reply-To: <2024010413-portable-lingo-3c11@gregkh>

On 4.1.2024 18.41, Greg KH wrote:
> On Thu, Jan 04, 2024 at 06:32:03PM +0200, niko.mauno@vaisala.com wrote:
...
>> +       The available values have the following meanings:
>> +             -1 is authorized for all devices (leftover from wireless USB)
>> +             0 is unauthorized for all devices
>> +             1 is authorized for all devices
> 
> What's the difference now between -1 and 1?  We don't have wireless USB
> anymore as that never turned into an actual product, so we shouldn't
> reference it anymore, right?
> 
> We should get rid of the -1 option entirely, but keep the module option
> and properly map it to '1'.
> 
> 
>> +             2 is authorized for internal devices
> 
> Needs a "if you don't know what to select, please choose X" text here.

Thanks, submitted v2 which strives to address also these considerations.
-Niko

  reply	other threads:[~2024-01-05 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 16:32 [PATCH] usb: core: Make default authorization mode configurable niko.mauno
2024-01-04 16:41 ` Greg KH
2024-01-05 11:56   ` Niko Mauno [this message]
2024-01-05 12:06     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522eb2bb-95d0-4e2f-a426-9347f14f51cb@vaisala.com \
    --to=niko.mauno@vaisala.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=vesa.jaaskelainen@vaisala.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox