From: dinghao.liu@zju.edu.cn
To: "Bin Liu" <b-liu@ti.com>
Cc: kjlu@umn.edu, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] usb: musb: Fix runtime PM imbalance on error
Date: Fri, 22 May 2020 09:23:01 +0800 (GMT+08:00) [thread overview]
Message-ID: <52fdeb8d.bcf65.17239f9f3a8.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20200521203728.GB25575@iaqt7>
Sure.
Regards,
Dinghao
> Hi,
>
> On Thu, May 21, 2020 at 03:35:47PM +0800, Dinghao Liu wrote:
> > When copy_from_user() returns an error code, a pairing
> > runtime PM usage counter decrement is needed to keep
> > the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> > drivers/usb/musb/musb_debugfs.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c
> > index 7b6281ab62ed..837c38a5e4ef 100644
> > --- a/drivers/usb/musb/musb_debugfs.c
> > +++ b/drivers/usb/musb/musb_debugfs.c
> > @@ -178,8 +178,11 @@ static ssize_t musb_test_mode_write(struct file *file,
> >
> > memset(buf, 0x00, sizeof(buf));
> >
> > - if (copy_from_user(buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
> > + if (copy_from_user(buf, ubuf, min_t(size_t, sizeof(buf) - 1, count))) {
> > + pm_runtime_mark_last_busy(musb->controller);
> > + pm_runtime_put_autosuspend(musb->controller);
> > return -EFAULT;
> > + }
>
> Thanks for catching the bug. Can you please instead move these lines to
> the beginning of this function so that pm_runtime_get_sync() is not
> called if copy_from_user() failed?
>
> -Bin.
prev parent reply other threads:[~2020-05-22 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 7:35 [PATCH] usb: musb: Fix runtime PM imbalance on error Dinghao Liu
2020-05-21 20:37 ` Bin Liu
2020-05-22 1:23 ` dinghao.liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52fdeb8d.bcf65.17239f9f3a8.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox