From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8875AC43331 for ; Thu, 2 Apr 2020 01:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6725E2077D for ; Thu, 2 Apr 2020 01:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732783AbgDBBeL (ORCPT ); Wed, 1 Apr 2020 21:34:11 -0400 Received: from mga07.intel.com ([134.134.136.100]:50388 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732435AbgDBBeL (ORCPT ); Wed, 1 Apr 2020 21:34:11 -0400 IronPort-SDR: ra9YLEl274kI59wj+a5RbZeX7jKAITXRVUj+ykR7Wp8jiR8Id2rs07wBcOxd+YoKogGPieVmww JVBEyNDdaLWA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2020 18:34:09 -0700 IronPort-SDR: DLqdeTOYf1qgCyqWcABZ76eQylWBG4nUtfyaR4TwN5AwSYlI27YVFKD+fyy3yED2/41SExpUBb OXBET1F/8Aow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,333,1580803200"; d="scan'208";a="422942571" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.3]) ([10.239.13.3]) by orsmga005.jf.intel.com with ESMTP; 01 Apr 2020 18:34:07 -0700 Subject: Re: [kbuild-all] Re: [RFC PATCH] usb: cdns3: cdns3_clear_register_bit() can be static From: Rong Chen To: Greg Kroah-Hartman Cc: kbuild test robot , Colin King , kbuild-all@lists.01.org, Sekhar Nori , Roger Quadros , Felipe Balbi , Pawel Laszczak , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200325125041.94769-1-colin.king@canonical.com> <20200326122858.GA50118@cde5a4ed3207> <20200326130418.GA1295433@kroah.com> <571960b6-5ed7-2106-7091-3ea83c31051a@intel.com> <20200327064255.GA1603489@kroah.com> <372f30ad-fbea-d411-c58f-2d4692509a60@intel.com> Message-ID: <556997e2-1921-e3dd-c103-d6e3c8f91888@intel.com> Date: Thu, 2 Apr 2020 09:33:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <372f30ad-fbea-d411-c58f-2d4692509a60@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 3/27/20 2:53 PM, Rong Chen wrote: > > > On 3/27/20 2:42 PM, Greg Kroah-Hartman wrote: >> On Fri, Mar 27, 2020 at 08:34:52AM +0800, Rong Chen wrote: >>> >>> On 3/26/20 9:04 PM, Greg Kroah-Hartman wrote: >>>> On Thu, Mar 26, 2020 at 08:28:58PM +0800, kbuild test robot wrote: >>>>> Fixes: 87db1192dc33 ("usb: cdns3: make signed 1 bit bitfields >>>>> unsigned") >>>> This original patch did not "cause" this problem, it's just that >>>> you for >>>> some reason ran sparse for the first time on the file. >>>> >>>> So I can't take this as-is, can you remove this line and resend? >>> Hi Greg, >>> >>> Sorry for the inconvenience, the patch was generated by the bot, >>> we'll check and resend it. >> It's fine that it was generated, it's a bug somewhere that thinks this >> specific patch was a problem so that this generated patch fixed it. > Yes, you are right, we'll fix the bug asap. > Hi Greg, The commit 87db1192dc33 ("usb: cdns3: make signed 1 bit bitfields unsigned") fixed a sparse error which causes many sparse warnings exposed, we'll remove the wrong "Fixes" in our patch in future. Best Regards, Rong Chen