Linux USB
 help / color / mirror / Atom feed
From: Klaus Kusche <klaus.kusche@computerix.info>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: oneukum@suse.com, sellis@redhat.com, linux-usb@vger.kernel.org
Subject: [Bug,200917] 4.18 regression: I/O error on external icybox disk enclosures
Date: Sun, 7 Oct 2018 17:11:54 +0200	[thread overview]
Message-ID: <55e076ff-e287-600c-e649-55b9ec9c4b5c@computerix.info> (raw)

Hello,

On 03/10/2018 16:02, Alan Stern wrote:
> Well, what happens if you add only US_FL_BROKEN_FUA without
> US_FL_IGNORE_UAS?  Does it work?

Tried all four combinations with gentoo 4.18.12.
Just US_FL_IGNORE_UAS fails with the error message in the original bug report.

The other three combinations (both flags removed, both flags set,
just US_FL_BROKEN_FUA set) work, at least for a quick test with ext4.

My guess:
Without US_FL_IGNORE_UAS (i.e. when using UAS),
the FUA command triggering the error is not used at all,
so US_FL_BROKEN_FUA doesn't make a difference.

> For that matter, does your kernel config include the uas driver?

Yes, it does.


I think we have to wait for sellis@redhat.com .
He could tell why he added US_FL_IGNORE_UAS,
if it's really needed, and why it was not included in mainline.

However, as US_FL_BROKEN_FUA is set for JMS567,
it is perhaps a good idea to set it for JMS566, too,
independent of US_FL_IGNORE_UAS (which is not set for JMS567).

             reply	other threads:[~2018-10-07 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-07 15:11 Klaus Kusche [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-07 20:27 [Bug,200917] 4.18 regression: I/O error on external icybox disk enclosures Alan Stern
2018-10-03 14:02 Alan Stern
2018-10-03 10:18 Klaus Kusche
2018-09-09 19:28 Alan Stern
2018-09-09  8:57 Klaus Kusche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55e076ff-e287-600c-e649-55b9ec9c4b5c@computerix.info \
    --to=klaus.kusche@computerix.info \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=sellis@redhat.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox