From: Ryan Brue <ryanbrue.dev@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH RESEND] usb: mtu3: don't run gadget completion callbacks with interrupts disabled
Date: Tue, 3 Nov 2026 17:29:32 -0600 [thread overview]
Message-ID: <56615102-0fad-4591-bee1-04d1efbd87b5@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-193807@kernel.org>
On 11/2/26 11:10 AM, sashiko-bot@kernel.org wrote:
> [Severity: High]
> Does replacing spin_lock_irqsave() with spin_lock_bh() in mtu3_irq() break
> the USB gadget completion contract and risk a hardirq deadlock?
>
> [...]
>
> Should mtu3_irq() wrap spin_lock_irqsave() and spin_unlock_irqrestore()
> with local_bh_disable() and local_bh_enable() instead of using
> spin_lock_bh()?
Yes. With spin_lock_bh() the completion callbacks run with interrupts
enabled, which usb_request's @complete doesn't allow.
I'll send a v2 that keeps spin_lock_irqsave() in mtu3_irq() and disables
bottom halves around it, like dwc3 does in commit 84918a89d6ef ("usb:
dwc3: gadget: Let the
interrupt handler disable bottom halves.").
Thanks bot :)
Ryan
next prev parent reply other threads:[~2026-11-03 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 16:29 [PATCH RESEND] usb: mtu3: don't run gadget completion callbacks with interrupts disabled Ryan Brue
2026-11-02 17:10 ` sashiko-bot
2026-11-03 23:29 ` Ryan Brue [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-29 15:04 Ryan Brue
2026-11-02 3:45 ` Ryan Brue
2026-11-20 12:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56615102-0fad-4591-bee1-04d1efbd87b5@gmail.com \
--to=ryanbrue.dev@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox