From: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 1/9] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible
Date: Mon, 22 Sep 2025 13:52:59 -0700 [thread overview]
Message-ID: <588fd98b-ed22-2940-a749-d4601f77b0b1@oss.qualcomm.com> (raw)
In-Reply-To: <nkkimxkdp3q3iiyv4ic6rxnwwedq5tnnn2zismqf4pdocvmono@xltxaqz6rb5q>
On 9/20/2025 8:18 AM, Dmitry Baryshkov wrote:
> On Fri, Sep 19, 2025 at 08:21:00PM -0700, Wesley Cheng wrote:
>> Define a Glymur compatible string for the QMP PHY combo driver, along with
>> resource requirements. Add a different identifier for the primary QMP PHY
>> instance as it does not require a clkref entry.
>
> Are register programming the same for both of them or not? If it's the
> same, it might be not necessary to have different compatibles.
>
Hi Dmitry,
Yes, the register programming sequences are the same, but the number of
clocks are different between the primary and the other controllers.
Specifically, on the primary USB controller, we don't have a clkref in
the TCSR. Was just adding a separate compatible ID to define the max
clock items. However, I do see that even if I only need 4 clks (for the
primary) it technically doesn't break the DT bindings definition, as
minItems = 4 and maxItems = 5 for the clock and clock-names fields.
I'll just go back to one compat for the primary and other controllers.
Thanks
Wesley Cheng
>>
>> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
>> ---
>> .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 45 ++++++++++++-------
>> 1 file changed, 28 insertions(+), 17 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> index 38ce04c35d94..e0b10725a1c5 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>> @@ -15,22 +15,28 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - qcom,sar2130p-qmp-usb3-dp-phy
>> - - qcom,sc7180-qmp-usb3-dp-phy
>> - - qcom,sc7280-qmp-usb3-dp-phy
>> - - qcom,sc8180x-qmp-usb3-dp-phy
>> - - qcom,sc8280xp-qmp-usb43dp-phy
>> - - qcom,sdm845-qmp-usb3-dp-phy
>> - - qcom,sm6350-qmp-usb3-dp-phy
>> - - qcom,sm8150-qmp-usb3-dp-phy
>> - - qcom,sm8250-qmp-usb3-dp-phy
>> - - qcom,sm8350-qmp-usb3-dp-phy
>> - - qcom,sm8450-qmp-usb3-dp-phy
>> - - qcom,sm8550-qmp-usb3-dp-phy
>> - - qcom,sm8650-qmp-usb3-dp-phy
>> - - qcom,sm8750-qmp-usb3-dp-phy
>> - - qcom,x1e80100-qmp-usb3-dp-phy
>> + oneOf:
>> + - items:
>> + - enum:
>> + - qcom,glymur-qmp-usb3-prim-dp-phy
>> + - const: qcom,glymur-qmp-usb3-dp-phy
>> + - enum:
>> + - qcom,glymur-qmp-usb3-dp-phy
>> + - qcom,sar2130p-qmp-usb3-dp-phy
>> + - qcom,sc7180-qmp-usb3-dp-phy
>> + - qcom,sc7280-qmp-usb3-dp-phy
>> + - qcom,sc8180x-qmp-usb3-dp-phy
>> + - qcom,sc8280xp-qmp-usb43dp-phy
>> + - qcom,sdm845-qmp-usb3-dp-phy
>> + - qcom,sm6350-qmp-usb3-dp-phy
>> + - qcom,sm8150-qmp-usb3-dp-phy
>> + - qcom,sm8250-qmp-usb3-dp-phy
>> + - qcom,sm8350-qmp-usb3-dp-phy
>> + - qcom,sm8450-qmp-usb3-dp-phy
>> + - qcom,sm8550-qmp-usb3-dp-phy
>> + - qcom,sm8650-qmp-usb3-dp-phy
>> + - qcom,sm8750-qmp-usb3-dp-phy
>> + - qcom,x1e80100-qmp-usb3-dp-phy
>>
>> reg:
>> maxItems: 1
>> @@ -46,7 +52,7 @@ properties:
>> - const: ref
>> - const: com_aux
>> - const: usb3_pipe
>> - - const: cfg_ahb
>> + - enum: [cfg_ahb, clkref]
>>
>> power-domains:
>> maxItems: 1
>> @@ -63,6 +69,8 @@ properties:
>>
>> vdda-pll-supply: true
>>
>> + refgen-supply: true
>> +
>> "#clock-cells":
>> const: 1
>> description:
>> @@ -110,6 +118,7 @@ allOf:
>> properties:
>> compatible:
>> enum:
>> + - qcom,glymur-qmp-usb3-dp-phy
>> - qcom,sc7180-qmp-usb3-dp-phy
>> - qcom,sdm845-qmp-usb3-dp-phy
>> then:
>> @@ -129,6 +138,8 @@ allOf:
>> properties:
>> compatible:
>> enum:
>> + - qcom,glymur-qmp-usb3-dp-phy
>> + - qcom,glymur-qmp-usb3-prim-dp-phy
>> - qcom,sar2130p-qmp-usb3-dp-phy
>> - qcom,sc8280xp-qmp-usb43dp-phy
>> - qcom,sm6350-qmp-usb3-dp-phy
>>
>> --
>> linux-phy mailing list
>> linux-phy@lists.infradead.org
>> https://lists.infradead.org/mailman/listinfo/linux-phy
>
next prev parent reply other threads:[~2025-09-22 20:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 3:20 [PATCH 0/9] Introduce Glymur USB support Wesley Cheng
2025-09-20 3:21 ` [PATCH 1/9] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible Wesley Cheng
2025-09-20 15:18 ` Dmitry Baryshkov
2025-09-22 20:52 ` Wesley Cheng [this message]
2025-09-24 12:31 ` Konrad Dybcio
2025-09-20 3:21 ` [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible Wesley Cheng
2025-09-20 15:22 ` Dmitry Baryshkov
2025-09-23 1:00 ` Wesley Cheng
2025-09-23 3:40 ` Dmitry Baryshkov
2025-09-23 19:36 ` Wesley Cheng
2025-09-23 7:27 ` Johan Hovold
2025-09-23 21:51 ` Wesley Cheng
2025-09-20 3:21 ` [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Wesley Cheng
2025-09-22 20:14 ` Rob Herring
2025-09-23 1:02 ` Wesley Cheng
2025-09-24 1:00 ` Wesley Cheng
2025-09-20 3:21 ` [PATCH 4/9] dt-bindings: usb: qcom,snps-dwc3: " Wesley Cheng
2025-09-20 3:21 ` [PATCH 5/9] phy: qualcomm: Update the QMP clamp register for V6 Wesley Cheng
2025-09-20 15:28 ` Dmitry Baryshkov
2025-09-20 3:21 ` [PATCH 6/9] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Wesley Cheng
2025-09-20 15:31 ` Dmitry Baryshkov
2025-09-20 17:12 ` kernel test robot
2025-09-20 3:21 ` [PATCH 7/9] phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY Wesley Cheng
2025-09-20 3:21 ` [PATCH 8/9] phy: qualcomm: m31-eusb2: Make clkref an optional resource Wesley Cheng
2025-09-20 15:33 ` Dmitry Baryshkov
2025-09-20 3:21 ` [PATCH 9/9] phy: qualcomm: m31-eusb2: Make USB repeater optional Wesley Cheng
2025-09-20 15:42 ` Dmitry Baryshkov
2025-09-23 1:03 ` Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588fd98b-ed22-2940-a749-d4601f77b0b1@oss.qualcomm.com \
--to=wesley.cheng@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox