linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: "xiaowei.li" <xiaowei.li@simcom.com>, Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: add SIMCom 8230C compositions
Date: Fri, 8 Aug 2025 00:27:45 +0700	[thread overview]
Message-ID: <58ac9a75-6b0d-4b13-9be4-89a46b8e4136@gmail.com> (raw)
In-Reply-To: <20250807075215.300961-1-xiaowei.li@simcom.com>

On 2025-08-07 14:52, xiaowei.li wrote:
> Add the following SIMCom 8230C compositions:
> 0x9071: tty (DM) + tty (NMEA) + tty (AT) + rmnet

snip

> ---
>   drivers/usb/serial/option.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e5cd33093423..8c4d28dfd64e 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2097,6 +2097,12 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9003, 0xff) },	/* Simcom SIM7500/SIM7600 MBIM mode */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9011, 0xff),	/* Simcom SIM7500/SIM7600 RNDIS mode */
>   	  .driver_info = RSVD(7) },
> +	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x907b, 0xff),
> +	  .driver_info = RSVD(5) },
> +	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9078, 0xff),
> +	  .driver_info = RSVD(5) },
> +	{ USB_DEVICE(0x1e0e, 0x9071),
> +	  .driver_info = RSVD(3) | RSVD(4) },
>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9205, 0xff) },	/* Simcom SIM7070/SIM7080/SIM7090 AT+ECM mode */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x1e0e, 0x9206, 0xff) },	/* Simcom SIM7070/SIM7080/SIM7090 AT-only mode */
>   	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S_X200),

Hi,
you are blacklisting interfaces 4 and 5 which are not present in your 
usb-devices listings and which are also not included in your interface 
function description.
You need to state the interface function which you can do as  .....tty 
(AT) + rmnet + {ADB} and also explain why the interface is hidden in
your usb-devices listings.

thanks
Lars




  parent reply	other threads:[~2025-08-07 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07  7:52 [PATCH] USB: serial: option: add SIMCom 8230C compositions xiaowei.li
2025-08-07 16:01 ` Greg Kroah-Hartman
2025-08-07 17:27 ` Lars Melin [this message]
2025-08-08  3:03   ` xiaowei.li
2025-08-26  9:53     ` Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2025-08-14  8:38 xiaowei.li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58ac9a75-6b0d-4b13-9be4-89a46b8e4136@gmail.com \
    --to=larsm17@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=xiaowei.li@simcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).