From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2
Date: Wed, 10 Jun 2020 23:43:46 +0800 [thread overview]
Message-ID: <591D2A1F-9645-4B0B-896C-99544F06DFAA@canonical.com> (raw)
In-Reply-To: <20200610143220.GC11727@rowland.harvard.edu>
> On Jun 10, 2020, at 22:32, Alan Stern <stern@rowland.harvard.edu> wrote:
>
> On Wed, Jun 10, 2020 at 02:42:30PM +0800, Kai-Heng Feng wrote:
>> xHCI spec "4.15.1 Port Suspend" states that port can be put to U3 as long
>> as Enabled bit is set and from U0, U1 or U2 state.
>>
>> Currently only USB_PORT_FEAT_LINK_STATE puts port to U3 directly, let's
>> do the same for USB_PORT_FEAT_SUSPEND and bus suspend case.
>>
>> This is particularly useful for USB2 devices, which may take a very long
>> time to switch USB2 LPM on and off.
>
> Have these two patches been tested with a variety of USB-2.0 and USB-2.1
> devices?
I tested some laptops around and they work fine.
Only internally connected USB devices like USB Bluetooth and USB Camera have USB2 LPM enabled, so this patch won't affect external connected devices.
Kai-Heng
>
> Alan Stern
next prev parent reply other threads:[~2020-06-10 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 6:42 [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2 Kai-Heng Feng
2020-06-10 6:42 ` [PATCH 2/2] USB: hub: Suspend and resume port with LPM enabled Kai-Heng Feng
2020-06-10 9:21 ` Sergei Shtylyov
2020-06-10 14:32 ` [PATCH 1/2] xhci: Suspend ports to U3 directly from U1 or U2 Alan Stern
2020-06-10 15:43 ` Kai-Heng Feng [this message]
2020-06-10 15:58 ` Mathias Nyman
2020-06-11 7:41 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591D2A1F-9645-4B0B-896C-99544F06DFAA@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox