regarding runtime PM in pegasus_notetaker

[Oliver Neukum <oneukum@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi,

the driver takes a PM reference in open(), yet it marks
the device busy in pegasus_irq(). These approaches contradict
each other. There is no point in marking a device as busy
while its PM count is elevated. It will not be runtime suspended
anyway.

Did you mean for the device to be subjected to runtime PM
while in use? If so, could you test the attached patch?

	Regards
		Oliver

[-- Attachment #2: 0001-hid-pegasus_notetaker-runtime-PM-while-open.patch --]
[-- Type: text/x-patch, Size: 1988 bytes --]

From 62e8faf509e2ad464b39b6bf7bc324d6d93c50d5 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Wed, 25 Mar 2026 14:58:32 +0100
Subject: [PATCH] hid: pegasus_notetaker: runtime PM while open

This implements runtime PM while the device is open
by dropping the reference in open and using remote
wakeup.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/input/tablet/pegasus_notetaker.c | 25 +++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c
index 4ce20befc657..3a8493ed5e44 100644
--- a/drivers/input/tablet/pegasus_notetaker.c
+++ b/drivers/input/tablet/pegasus_notetaker.c
@@ -211,10 +211,21 @@ static void pegasus_init(struct work_struct *work)
 	struct pegasus *pegasus = container_of(work, struct pegasus, init);
 	int error;
 
+	error = usb_autopm_get_interface(pegasus->intf);
+	if (error)
+		goto bail;
 	error = pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
 	if (error)
-		dev_err(&pegasus->usbdev->dev, "pegasus_set_mode error: %d\n",
-			error);
+		goto bail_pm;
+
+	usb_autopm_put_interface(pegasus->intf);
+	return;
+
+bail_pm:
+	usb_autopm_put_interface(pegasus->intf);
+bail:
+	dev_err(&pegasus->usbdev->dev, "pegasus_set_mode error: %d\n",
+		error);
 }
 
 static int __pegasus_open(struct pegasus *pegasus)
@@ -249,12 +260,10 @@ static int pegasus_open(struct input_dev *dev)
 		return error;
 
 	error = __pegasus_open(pegasus);
-	if (error) {
-		usb_autopm_put_interface(pegasus->intf);
-		return error;
-	}
+	pegasus->intf->needs_remote_wakeup = 1;
+	usb_autopm_put_interface(pegasus->intf);
 
-	return 0;
+	return error;
 }
 
 static void pegasus_close(struct input_dev *dev)
@@ -267,8 +276,6 @@ static void pegasus_close(struct input_dev *dev)
 
 		pegasus->is_open = false;
 	}
-
-	usb_autopm_put_interface(pegasus->intf);
 }
 
 static int pegasus_probe(struct usb_interface *intf,
-- 
2.53.0