From: Eli Billauer <eli.billauer@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Subject: Re: [RFC]mooring API
Date: Mon, 10 Aug 2020 19:01:36 +0300 [thread overview]
Message-ID: <5F316F60.5090506@gmail.com> (raw)
In-Reply-To: <1597070349.2515.6.camel@suse.com>
On 10/08/20 17:39, Oliver Neukum wrote:
>> To me the anchor API is great. If there is unclearances about its API, I
>> > suppose docs would help. The fact that the URB is unanchored prior to
>> > calling the completer is intuitive, so there's a clear benefit in that.
>>
> But is it necessary? DO you ever move URBs between anchors?
>
I don't think it's relevant what I would or wouldn't do. The question is
if someone out there would do that. Without any guidelines saying it's
explicitly disallowed, some will do it. Actually, even if there are such
guidelines.
>
>> > This requires some ungraceful code where almost nobody's looking, but if
>> > that makes the common programmer's life easier, I think it's a good deal.
>>
> It would be, if the deal is necessary. In hindsight it still looks
> to me like completion should unanchor an URB.
>
Once again, I'm not sure that matters so much anymore. The anchor API
has been around for a while, and there are drivers using it. Adding
another API will undoubtedly create some confusion. That's why I think
that the question should be what is functionally flawed with the current
API, and if that can be fixed.
Regards,
Eli
prev parent reply other threads:[~2020-08-10 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 14:07 [RFC]mooring API Oliver Neukum
2020-08-06 15:20 ` Alan Stern
2020-08-10 14:35 ` Oliver Neukum
2020-08-10 15:17 ` Alan Stern
2020-08-11 17:39 ` Oliver Neukum
2020-08-11 18:01 ` Alan Stern
2020-08-06 16:14 ` Eli Billauer
2020-08-10 14:39 ` Oliver Neukum
2020-08-10 16:01 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F316F60.5090506@gmail.com \
--to=eli.billauer@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).