From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8351459F6; Sat, 21 Jun 2025 08:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750492916; cv=none; b=nPvksLUxxgvGn0xo2Byi7SrvH0CBtAFQmRu0X2aLpkctOu/y9knxZP6WurTOYbvmRXurph+vU8W+CRx3UmZomKg1FcsTnQweC3h5Ase1wze1truu5aV2inKgQfYxpcaEiqNWOsxlkN8iokS+IbjXGPRidrpeYt9ZZCcSZcLvu6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750492916; c=relaxed/simple; bh=O7kwbBlgpkTAY+8xG44BORrnfHtrt65qBceqCJuFong=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RdyeiPhZSCC7NUDvXeRVMDOcKeI8/lGOHcACa72WZIRbq/bq8vx110j+lxmqikvZ4njg0zdyQk47JINiNArEwI/81MFTSFJLA6ihL6SQNEuTW+wisfYDSbJqp06JYR7gXJcZh+snNj/U2wFBLbntyPbpXAt/IL8isW7LUWEMyQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=hXhQ/77i; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="hXhQ/77i" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=m1bFZYsCLNp2mN1YOVPVqOstkZgIwKgoP+6BvR6MCpc=; b=hXhQ/77im1dtpQfBmy42Bu0qSg OW8fQfF5qmq9MN/sEbCv31W3mJm5DZBzpflkNqn/qMdQjwHfFE9/DRJfN3MSWwGOp/uSZBGguiUZF RCxE+RFNiQE5xaMYE6OquNYCZQzs6wVIqdJ1HBuSNQV8++DQNEeYw/yVDnosmTqbTBlA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uStAZ-00GZJI-Jx; Sat, 21 Jun 2025 10:01:47 +0200 Date: Sat, 21 Jun 2025 10:01:47 +0200 From: Andrew Lunn To: Kory Maincent Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, Maxime Chevallier , thomas.petazzoni@bootlin.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Mark Einon , Shyam Sundar S K , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , =?utf-8?Q?=C5=81ukasz?= Stelmach , Michael Chan , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Doug Berger , Florian Fainelli , Pavan Chebbi , Sunil Goutham , Hans Ulli Kroll , Linus Walleij , Ioana Ciornei , Jijie Shao , Jian Shen , Salil Mehta , Sebastian Hesselbarth , Parthiban Veerasooran , Yoshihiro Shimoda , Niklas =?iso-8859-1?Q?S=F6derlund?= , MD Danish Anwar , Roger Quadros , Jiawen Wu , Mengyuan Lou , Imre Kaloz , Heiner Kallweit , Russell King , Steve Glendinning , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Richard Cochran Subject: Re: [PATCH net-next RFC] net: Throw ASSERT_RTNL into phy_detach Message-ID: <5c32afad-5e25-4a35-8bdd-b78949c117ce@lunn.ch> References: <20250620143341.2158655-1-kory.maincent@bootlin.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620143341.2158655-1-kory.maincent@bootlin.com> > +/** > + * phy_disconnect_rtnl - disable interrupts, stop state machine, and detach a PHY > + * device > + * @phydev: target phy_device struct > + * > + * This is a wrapper around phy_disconnect that takes the rtnl semaphore. > + */ Developers are likely to get this wrong, because generally they don't need to bother with RTNL, the core does it. Could you add some guidance here when this should be used, and when not. Andrew