* [v2,1/6] dt-bindings: connector: add optional properties for Type-B
@ 2019-03-15 7:38 Chunfeng Yun
0 siblings, 0 replies; 3+ messages in thread
From: Chunfeng Yun @ 2019-03-15 7:38 UTC (permalink / raw)
To: Rob Herring, Greg Kroah-Hartman, Heikki Krogerus
Cc: Mark Rutland, Chunfeng Yun, Matthias Brugger, Adam Thomson,
Li Jun, Badhri Jagan Sridharan, Hans de Goede, Andy Shevchenko,
Min Guo, devicetree, linux-kernel, linux-usb, linux-arm-kernel,
linux-mediatek
Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
usb-b-connector
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2 changes:
1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
---
.../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
index a9a2f2fc44f2..1c4ed6c9afa8 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
@@ -17,6 +17,15 @@ Optional properties:
- self-powered: Set this property if the usb device that has its own power
source.
+Optional properties for usb-b-connector:
+- id-gpios: gpio for USB ID pin.
+- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
+ see gpio/gpio.txt.
+- vbus-supply: a phandle to the regulator for USB VBUS if needed.
+- pinctrl-names : a pinctrl state named "default" is optional
+- pinctrl-0 : pin control group
+ see pinctrl/pinctrl-bindings.txt
+
Optional properties for usb-c-connector:
- power-role: should be one of "source", "sink" or "dual"(DRP) if typec
connector has power support.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v2,1/6] dt-bindings: connector: add optional properties for Type-B
@ 2019-03-31 6:40 Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-03-31 6:40 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Greg Kroah-Hartman, Heikki Krogerus, Mark Rutland,
Matthias Brugger, Adam Thomson, Li Jun, Badhri Jagan Sridharan,
Hans de Goede, Andy Shevchenko, Min Guo, devicetree, linux-kernel,
linux-usb, linux-arm-kernel, linux-mediatek
On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote:
> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
> usb-b-connector
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2 changes:
> 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
> ---
> .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index a9a2f2fc44f2..1c4ed6c9afa8 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -17,6 +17,15 @@ Optional properties:
> - self-powered: Set this property if the usb device that has its own power
> source.
>
> +Optional properties for usb-b-connector:
> +- id-gpios: gpio for USB ID pin.
> +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
> + see gpio/gpio.txt.
Please make it explicit that this is an input gpio. An output GPIO
controlling a Vbus regulator should be modelled as a regulator.
> +- vbus-supply: a phandle to the regulator for USB VBUS if needed.
> +- pinctrl-names : a pinctrl state named "default" is optional
> +- pinctrl-0 : pin control group
> + see pinctrl/pinctrl-bindings.txt
> +
> Optional properties for usb-c-connector:
> - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> connector has power support.
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v2,1/6] dt-bindings: connector: add optional properties for Type-B
@ 2019-03-31 12:45 Chunfeng Yun
0 siblings, 0 replies; 3+ messages in thread
From: Chunfeng Yun @ 2019-03-31 12:45 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Heikki Krogerus, Mark Rutland,
Matthias Brugger, Adam Thomson, Li Jun, Badhri Jagan Sridharan,
Hans de Goede, Andy Shevchenko, Min Guo, devicetree, linux-kernel,
linux-usb, linux-arm-kernel, linux-mediatek
Hi Rob,
On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote:
> On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote:
> > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
> > usb-b-connector
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2 changes:
> > 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
> > ---
> > .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > index a9a2f2fc44f2..1c4ed6c9afa8 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > @@ -17,6 +17,15 @@ Optional properties:
> > - self-powered: Set this property if the usb device that has its own power
> > source.
> >
> > +Optional properties for usb-b-connector:
> > +- id-gpios: gpio for USB ID pin.
> > +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
> > + see gpio/gpio.txt.
>
> Please make it explicit that this is an input gpio. An output GPIO
> controlling a Vbus regulator should be modelled as a regulator.
Ok, thanks
>
> > +- vbus-supply: a phandle to the regulator for USB VBUS if needed.
> > +- pinctrl-names : a pinctrl state named "default" is optional
> > +- pinctrl-0 : pin control group
> > + see pinctrl/pinctrl-bindings.txt
> > +
> > Optional properties for usb-c-connector:
> > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> > connector has power support.
> > --
> > 2.20.1
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-31 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-31 6:40 [v2,1/6] dt-bindings: connector: add optional properties for Type-B Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-03-31 12:45 Chunfeng Yun
2019-03-15 7:38 Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).