* [03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
@ 2019-04-01 12:53 ` Biju Das
2019-04-06 6:06 ` [PATCH 03/12] " Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Biju Das @ 2019-04-01 12:53 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Greg Kroah-Hartman, linux-usb, devicetree, Simon Horman,
Geert Uytterhoeven, Yoshihiro Shimoda, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
Add device tree binding document for Renesas r8a77470(a.k.a RZ/G1C)
on-chip EHCI controller driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
V1-->V2
* New patch
---
.../devicetree/bindings/usb/ehci-r8a77470.txt | 35 ++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
diff --git a/Documentation/devicetree/bindings/usb/ehci-r8a77470.txt b/Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
new file mode 100644
index 0000000..4646adcf
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
@@ -0,0 +1,35 @@
+Renesas R8A77470(RZ/G1C) USB EHCI controller
+
+Required properties:
+ - compatible : must be "renesas,r8a77470"
+ - reg : physical base addresses of the controller and length
+ of memory mapped region
+ - interrupts : one EHCI interrupt should be described here
+ - clocks : a list of phandle + clock specifier pairs.
+ - phys : see usb-hcd.txt in the current directory
+ - resets : phandle + reset specifier pair
+
+Additionally the properties from usb-hcd.txt (in the current directory) are
+supported.
+
+Example:
+
+ ehci0: usb@ee080100 {
+ compatible = "renesas,ehci-r8a77470";
+ reg = <0 0xee080100 0 0x800>;
+ interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 703>;
+ phys = <&usb0 0>;
+ phy-names = "usb";
+ resets = <&cpg 703>;
+ };
+
+ ehci1: usb@ee0c0100 {
+ compatible = "renesas,ehci-r8a77470";
+ reg = <0 0xee0c0100 0 0x800>;
+ interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 705>;
+ phys = <&usb0 1>, <&usb1 0>;
+ phy-names = "usb";
+ resets = <&cpg 705>;
+ };
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
2019-04-01 12:53 ` [03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document Biju Das
@ 2019-04-06 6:06 ` Rob Herring
2019-04-09 7:29 ` [03/12] " Biju Das
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2019-04-06 6:06 UTC (permalink / raw)
To: Biju Das
Cc: Mark Rutland, Biju Das, Greg Kroah-Hartman, linux-usb, devicetree,
Simon Horman, Geert Uytterhoeven, Yoshihiro Shimoda,
Chris Paterson, Fabrizio Castro, linux-renesas-soc
On Mon, 1 Apr 2019 13:53:43 +0100, Biju Das wrote:
> Add device tree binding document for Renesas r8a77470(a.k.a RZ/G1C)
> on-chip EHCI controller driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> V1-->V2
> * New patch
> ---
> .../devicetree/bindings/usb/ehci-r8a77470.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
@ 2019-04-09 7:29 ` Biju Das
2019-04-09 7:29 ` [PATCH 03/12] " Biju Das
2019-04-09 10:39 ` [03/12] " Yoshihiro Shimoda
0 siblings, 2 replies; 6+ messages in thread
From: Biju Das @ 2019-04-09 7:29 UTC (permalink / raw)
To: Rob Herring, Yoshihiro Shimoda, Alan Stern
Cc: Mark Rutland, Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro,
linux-renesas-soc@vger.kernel.org
Hi Rob,
Thanks for the review. I guess we need to drop this patch, if the solution proposed by Shimoda-San is acceptable by everyone.
The same result can be achieved without using this driver. I have posted V3 based on this. please see the link below.
https://patchwork.kernel.org/patch/10883263/
ehci-r8a77479 driver = generic ehci driver + phy initialization code of rcar-gen3-usb2 driver.
Regards,
Biju
> Subject: Re: [PATCH 03/12] dt-bindings: usb: ehci-r8a77470 devicetree
> binding document
>
> On Mon, 1 Apr 2019 13:53:43 +0100, Biju Das wrote:
> > Add device tree binding document for Renesas r8a77470(a.k.a RZ/G1C)
> > on-chip EHCI controller driver.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > V1-->V2
> > * New patch
> > ---
> > .../devicetree/bindings/usb/ehci-r8a77470.txt | 35
> ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
2019-04-09 7:29 ` [03/12] " Biju Das
@ 2019-04-09 7:29 ` Biju Das
2019-04-09 10:39 ` [03/12] " Yoshihiro Shimoda
1 sibling, 0 replies; 6+ messages in thread
From: Biju Das @ 2019-04-09 7:29 UTC (permalink / raw)
To: Rob Herring, Yoshihiro Shimoda, Alan Stern
Cc: Mark Rutland, Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro,
linux-renesas-soc@vger.kernel.org
Hi Rob,
Thanks for the review. I guess we need to drop this patch, if the solution proposed by Shimoda-San is acceptable by everyone.
The same result can be achieved without using this driver. I have posted V3 based on this. please see the link below.
https://patchwork.kernel.org/patch/10883263/
ehci-r8a77479 driver = generic ehci driver + phy initialization code of rcar-gen3-usb2 driver.
Regards,
Biju
> Subject: Re: [PATCH 03/12] dt-bindings: usb: ehci-r8a77470 devicetree
> binding document
>
> On Mon, 1 Apr 2019 13:53:43 +0100, Biju Das wrote:
> > Add device tree binding document for Renesas r8a77470(a.k.a RZ/G1C)
> > on-chip EHCI controller driver.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > V1-->V2
> > * New patch
> > ---
> > .../devicetree/bindings/usb/ehci-r8a77470.txt | 35
> ++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/usb/ehci-r8a77470.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
@ 2019-04-09 10:39 ` Yoshihiro Shimoda
2019-04-09 10:39 ` [PATCH 03/12] " Yoshihiro Shimoda
0 siblings, 1 reply; 6+ messages in thread
From: Yoshihiro Shimoda @ 2019-04-09 10:39 UTC (permalink / raw)
To: Biju Das, Rob Herring, Alan Stern
Cc: Mark Rutland, Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro,
linux-renesas-soc@vger.kernel.org
Hi Biju-san,
> From: Biju Das, Sent: Tuesday, April 9, 2019 4:30 PM
>
> Hi Rob,
>
> Thanks for the review. I guess we need to drop this patch, if the solution proposed by Shimoda-San is acceptable by everyone.
> The same result can be achieved without using this driver. I have posted V3 based on this. please see the link below.
>
> https://patchwork.kernel.org/patch/10883263/
>
> ehci-r8a77479 driver = generic ehci driver + phy initialization code of rcar-gen3-usb2 driver.
I accept v3 based patches (for now I checked patch 1 to 4 only though).
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document
2019-04-09 10:39 ` [03/12] " Yoshihiro Shimoda
@ 2019-04-09 10:39 ` Yoshihiro Shimoda
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2019-04-09 10:39 UTC (permalink / raw)
To: Biju Das, Rob Herring, Alan Stern
Cc: Mark Rutland, Greg Kroah-Hartman, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro,
linux-renesas-soc@vger.kernel.org
Hi Biju-san,
> From: Biju Das, Sent: Tuesday, April 9, 2019 4:30 PM
>
> Hi Rob,
>
> Thanks for the review. I guess we need to drop this patch, if the solution proposed by Shimoda-San is acceptable by everyone.
> The same result can be achieved without using this driver. I have posted V3 based on this. please see the link below.
>
> https://patchwork.kernel.org/patch/10883263/
>
> ehci-r8a77479 driver = generic ehci driver + phy initialization code of rcar-gen3-usb2 driver.
I accept v3 based patches (for now I checked patch 1 to 4 only though).
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-09 10:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1554123232-58942-1-git-send-email-biju.das@bp.renesas.com>
2019-04-01 12:53 ` [03/12] dt-bindings: usb: ehci-r8a77470 devicetree binding document Biju Das
2019-04-06 6:06 ` [PATCH 03/12] " Rob Herring
2019-04-09 7:29 ` [03/12] " Biju Das
2019-04-09 7:29 ` [PATCH 03/12] " Biju Das
2019-04-09 10:39 ` [03/12] " Yoshihiro Shimoda
2019-04-09 10:39 ` [PATCH 03/12] " Yoshihiro Shimoda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).