From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED9C14A8B for ; Sat, 8 Mar 2025 18:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741458456; cv=none; b=kYc/sbQnofcY8qmJwzUKhUpsstk6YRZMzrV/DcoJwIcvHtMPKI83DOcbvJUR6yAVAaIxuARuFdKivjw9VJgeV+1arMr4kpRzvDXh6+lCyuzu1hyJ2NngBCog8PUZiK4WHeDc70wfytvBPi/emYQIUwPTwnDHzzTi7qsN0YnYJRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741458456; c=relaxed/simple; bh=mZGJjE9J6nPENdw3R6qHpn+oUR2EHsw7Roao2Jmba9Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qS6wxASJlj8yiqQpxwk7iMKThZA0/EIFj5/+A9otcVm/WbpCAV2c4Zy/dg1/yye9ReVIhDXuN4P3w1tGm6GIHEj0MrCdrzTEGwKDeLtQRgMD994qjbrmrChycM3F3qB4XT4AZDGW48iWCs9Z8ztYiQ45ajThvNA/u2lDFkQWUBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JNtpSbwW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JNtpSbwW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 528HZ1XS026628 for ; Sat, 8 Mar 2025 18:27:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zm0fIbKt1P+B2YQrFVSHiI90y5gg5UDdQQYWtWf2GJI=; b=JNtpSbwW8dsjbr/H f19TfEd8t7QRUnEu/7BCBDxqsGHsTXBGIppFMznXS9cZpRGjP2mc340LJ474hRIH SjQjqsqaIeJsoevM98BL5jGVZD3sW+9/b84ut5aj2yG0J2s4f9bjiOx0nJLj4U2T 46mHiWjxi3zIDr7qOMksuw47IRiRvMmnoTPHL/T9I4/zUsfMuEmmap8Qu25j4SNJ pPAybhpmhvANMhGvRMm8dOqQKVkPYiPUCjV3G8UYp4/5yv7/6CgZO+Dn7eBtfdhn hwF7DERyStMp0C5M92xkDvlxazcADd3hDVyhDHXJdXwv5PJv30V8mRYZFZWn8b6z KrcIig== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 458f6a8y1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 08 Mar 2025 18:27:33 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6e8f3c21043so8043476d6.1 for ; Sat, 08 Mar 2025 10:27:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741458452; x=1742063252; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zm0fIbKt1P+B2YQrFVSHiI90y5gg5UDdQQYWtWf2GJI=; b=xJR32t1ihpZ8hYGSDII+RdWvaWI+HW9J4dqm+2lWh+j2ivCOnJGGfp9uyNdPG9UyU2 NxTblnM7ccGIgRKncK0Ex0IMTWRSurPm4EKrkmuSIz1Bo0PMef+3k2c1yaK4kiz0Av9o EgbqZIFLSa3gTmgfVGJ3FVygyWj8xnK0fWGvC5tgLsnmsFOyKGl1R8eVC3cWjO+nd4Pl ofIxqwlJFNo/W8WYlTWcrDTO7wQ35xQF7y8uCkyU/CueIMXGt4gmC8pc8Mx6AomiLHwj 4o0pHMgOaTRpkDD+GnBJFJnTWEKUgPVRCx0FT/kLu+DPKxLqpxq+jWauYomWu5AUWLPY sAQw== X-Forwarded-Encrypted: i=1; AJvYcCWSwokSMyXdvJQ2zJmArpHaFMiMutUWXIeQm+wXkZboc7kgUhT38FKQxr4L3YVEuOKioJFQdtLPZrY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn5aA3TTTzroNVPdt92JISDkCvFkzP01Dva/q65NcVLSdOD4Xt d0H3KAvOV47BRYmrHuKMd9yBzRwehVCZR0lP2qz267TPx8/fszEW8VgEJRWqdFXKDmFfZ6RfzyK dzaS2V7sZwyiztjG20Gn2zuo4X4gvy1LtNkrgIxwSqlQwQE0V5UMflab9UTg= X-Gm-Gg: ASbGncvi19u9YZD/XrHPbGWDmC3Wb85O09BS8kvNjuQoce7xpcQ1ZtNw+C7KmGxw0uj sAywOftK18NRQsvIaH6WjHf2KL7DwJkSveDZXzBAe19UqbbshHkZxonRulGWgFBku7jATW8rtCv P9s8iYrQsypvbwHHZXWeupQTwhR09gQEqSqXolMghmoxfQPNU8Ls/DtISBSEgLPuT8JyAFKN2mk fja9S8MvQN4ED6MKhymk9B9Z/6dUEhkBuF1DQtEefqXU/KeyVf/dTUqZyQ3VracmT0NIo3bC0bX PAVKc0mdDqPWS4wF4TFIphCr4mMDCWImOm/oTlb7ML9Ro3w8G4Eb3IJFdXP4VBfJYFugtg== X-Received: by 2002:a05:6214:501c:b0:6e6:60f6:56dd with SMTP id 6a1803df08f44-6e908daad6amr19155036d6.7.1741458452573; Sat, 08 Mar 2025 10:27:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuhNwOobWK10InZ0rt9nJA/hwpNz+zn+BWgUcVkO6LwDiLCRj4SL3cJNEIriGAfDjmRZv6Xg== X-Received: by 2002:a05:6214:501c:b0:6e6:60f6:56dd with SMTP id 6a1803df08f44-6e908daad6amr19154896d6.7.1741458451981; Sat, 08 Mar 2025 10:27:31 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac239482f9asm479537266b.51.2025.03.08.10.27.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Mar 2025 10:27:31 -0800 (PST) Message-ID: <5ef97125-2b27-4961-8755-09fcea062f78@oss.qualcomm.com> Date: Sat, 8 Mar 2025 19:27:28 +0100 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] usb: common: usb-conn-gpio: switch psy_cfg from of_node to fwnode To: Greg Kroah-Hartman , Sebastian Reichel , Konstantin Ryabitsev Cc: Mark Brown , Linus Walleij , Hans de Goede , Liam Girdwood , Chen-Yu Tsai , Matti Vaittinen , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Paul Cercueil , Samuel Holland , David Lechner , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , Bartosz Golaszewski , Konrad Dybcio , Matthias Brugger , AngeloGioacchino Del Regno , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20250225-psy-core-convert-to-fwnode-v1-0-d5e4369936bb@collabora.com> <20250225-psy-core-convert-to-fwnode-v1-3-d5e4369936bb@collabora.com> <2025022542-recital-ebony-d9b5@gregkh> <2025030845-pectin-facility-a474@gregkh> <0401fdf9-7665-40d6-9ec7-7222b2eda866@oss.qualcomm.com> <2025030831-various-monthly-4ae0@gregkh> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2025030831-various-monthly-4ae0@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=WsDRMcfv c=1 sm=1 tr=0 ts=67cc8c15 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=QX4gbG5DAAAA:8 a=ag1SF4gXAAAA:8 a=A6-iuEzwBZR8Vts4HQEA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=AbAUZ8qAyYyZVLSsDulk:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-Proofpoint-GUID: OCxoiUz-1qXX_aO2S2yNV03xHjuEn-PM X-Proofpoint-ORIG-GUID: OCxoiUz-1qXX_aO2S2yNV03xHjuEn-PM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-08_07,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503080142 On 8.03.2025 6:27 PM, Greg Kroah-Hartman wrote: > On Sat, Mar 08, 2025 at 05:33:05PM +0100, Sebastian Reichel wrote: >> Hi, >> >> On Sat, Mar 08, 2025 at 10:34:45AM +0100, Konrad Dybcio wrote: >>> On 8.03.2025 6:57 AM, Greg Kroah-Hartman wrote: >>>> On Sat, Mar 08, 2025 at 02:10:29AM +0100, Sebastian Reichel wrote: >>>>> On Tue, Feb 25, 2025 at 04:32:50AM +0100, Greg Kroah-Hartman wrote: >>>>>> On Tue, Feb 25, 2025 at 12:21:36AM +0100, Sebastian Reichel wrote: >>>>>>> In order to remove .of_node from the power_supply_config struct, >>>>>>> use .fwnode instead. >>>>>>> >>>>>>> Signed-off-by: Sebastian Reichel >>>>>>> --- >>>>>>> drivers/usb/common/usb-conn-gpio.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c >>>>>>> index aa710b50791b0282be0a6a26cffdd981b794acaa..1e36be2a28fd5ca5e1495b7923e4d3e25d7cedef 100644 >>>>>>> --- a/drivers/usb/common/usb-conn-gpio.c >>>>>>> +++ b/drivers/usb/common/usb-conn-gpio.c >>>>>>> @@ -158,7 +158,7 @@ static int usb_conn_psy_register(struct usb_conn_info *info) >>>>>>> struct device *dev = info->dev; >>>>>>> struct power_supply_desc *desc = &info->desc; >>>>>>> struct power_supply_config cfg = { >>>>>>> - .of_node = dev->of_node, >>>>>>> + .fwnode = dev_fwnode(dev), >>>>>>> }; >>>>>>> >>>>>>> desc->name = "usb-charger"; >>>>>>> >>>>>>> -- >>>>>>> 2.47.2 >>>>>> >>>>>> Acked-by: Greg Kroah-Hartman >>>>> >>>>> Please just merge this patch through the USB tree. >>>>> >>>>> There are no dependencies and I will send a new version for the >>>>> later patches, but they won't make it to 6.15 as I want enough >>>>> time in linux-next for them. This patch is rather simple and >>>>> getting it merged now means we avoid immutable branches or >>>>> merging through the wrong tree in the 6.16 cycle. >>>> >>>> Attempting to merge a single patch out of a series is hard with our >>>> current tools, you know that. >> >> Sorry, I did not know your tooling has issues with that. AFAIK most >> maintainers are using b4 nowadays, which makes it really easy. Might >> be I am biased because I mostly work on ARM stuff where series often >> have patches for the driver and the device tree and thus merging >> partial patch series is basically the norm. > > I do use b4, but it wants to suck the whole series down. If I want to > pick an individual one out, I have to manually cut the message-id out > of the email and type out the command and pick the individual commit > out (or use the -P 3 as was said). > > But that's a world away from me just hitting a single key in my email > client to suck down the whole thread and apply it to my tree. > > For those of us who have to apply a lot of patches, automation is key. > When sending a patch series that wants to be split across multiple > trees, that makes it harder for everyone. > > Anyway, I can take this as is, I've spent more time typing this than it > would have taken me to dig out just the single email. Give me a few > days to catch up with it... Maybe +Konstantin has a better idea, but b4 shazam --single-message works too, provided you use the very msgid of the patch (i.e. not a reply to it or so) and should be easy to add a keybind for Konrad